Upgrade to wasmvm v0.14.0-rc1 #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webmaster128
approved these changes
Apr 29, 2021
| if sec < 0 { | ||
| panic("Block (unix) time must never be negative ") | ||
| nano := ctx.BlockTime().UnixNano() | ||
| if nano < 1 { |
There was a problem hiding this comment.
A 0 time is well supported in this case. It is serialized as "0" because of string in
Time uint64 `json:"time,string"`
. But this way works as well.
There was a problem hiding this comment.
IMHO there is no realistic scenario with timestamp 0 and we should fail fast. While genesis block has height 0 it does contain a >0 timestamp.
|
Fixing contracts here: CosmWasm/cosmwasm#910 I will compile and try to fix the test now |
Codecov Report
@@ Coverage Diff @@
## master #508 +/- ##
==========================================
+ Coverage 58.54% 58.68% +0.13%
==========================================
Files 43 43
Lines 4525 4504 -21
==========================================
- Hits 2649 2643 -6
+ Misses 1660 1644 -16
- Partials 216 217 +1
|
|
@ethanfrey thanks a lot for the contract fix 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to wasmvm v0.14.0-rc1
Deactivated
ibc_reflect_test