Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add data field to Instantiate response #427

Merged
merged 2 commits into from
Mar 3, 2021
Merged

Add data field to Instantiate response #427

merged 2 commits into from
Mar 3, 2021

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Mar 3, 2021

Resolves #385

New field in MsgInstantiateContractResponse and minor refactoring to testing framework.

@alpe alpe marked this pull request as draft March 3, 2021 10:17
@codecov
Copy link

codecov bot commented Mar 3, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@cca60e2). Click here to learn what that means.
The diff coverage is 53.84%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #427   +/-   ##
=========================================
  Coverage          ?   55.39%           
=========================================
  Files             ?       39           
  Lines             ?     4022           
  Branches          ?        0           
=========================================
  Hits              ?     2228           
  Misses            ?     1615           
  Partials          ?      179
Impacted Files Coverage Δ
x/wasm/internal/keeper/msg_server.go 0.00% <0.00%> (ø)
x/wasm/internal/keeper/keeper.go 88.91% <60.00%> (ø)
x/wasm/internal/keeper/proposal_handler.go 57.54% <100.00%> (ø)

ethanfrey
ethanfrey approved these changes Mar 3, 2021
View reviewed changes
Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One little nit.

I think you have a good point of the data not being returned for any of the calls via governance. I would address that in another PR, as that is not just about instantiate.

x/wasm/internal/types/tx.proto Outdated Show resolved Hide resolved
@alpe
Copy link
Contributor Author

alpe commented Mar 3, 2021

I have created #431 to follow up on the events

@alpe alpe marked this pull request as ready for review March 3, 2021 13:39
@alpe alpe force-pushed the instantiate_rsp_data_385 branch from cd65b4c to 4a3e12a Compare March 3, 2021 13:49
@alpe
Copy link
Contributor Author

alpe commented Mar 3, 2021

Sorry, had to push -f after merge conflicts.

@ethanfrey
Copy link
Member

I have created #431 to follow up on the events

Great. and for 0.17 😄 (Actually events are non-breaking, so that could be 0.16.1).

Feel free to merge when CI finally runs

@ethanfrey ethanfrey merged commit 573bada into master Mar 3, 2021
@alpe alpe deleted the instantiate_rsp_data_385 branch September 15, 2021 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanfrey ethanfrey ethanfrey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add MsgInstantiateContractResponse.data
2 participants
@alpe @ethanfrey