chore: update ibc-go v10 to beta.1 #2139
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2139 +/- ##
==========================================
- Coverage 46.12% 45.98% -0.14%
==========================================
Files 78 78
Lines 10731 10685 -46
==========================================
- Hits 4950 4914 -36
+ Misses 5339 5334 -5
+ Partials 442 437 -5
|
| @@ -567,7 +557,7 @@ func NewWasmApp( | |||
| appCodec, | |||
| runtime.NewKVStoreService(keys[icahosttypes.StoreKey]), | |||
| app.GetSubspace(icahosttypes.SubModuleName), | |||
| app.IBCFeeKeeper, // use ics29 fee as ics4Wrapper in middleware stack | |||
| app.IBCKeeper.ChannelKeeper, | |||
| app.IBCKeeper.ChannelKeeper, | |||
There was a problem hiding this comment.
This app.IBCKeeper.ChannelKeeper, app.IBCKeeper.ChannelKeeper, looks fishy
There was a problem hiding this comment.
It is correct here though, as there is no stack (porttypes.ICS4Wrapper), so we can just use the channelkeeper as the stack.
| }, | ||
| PacketFee: ibcfeetypes.NewPacketFee(fee, sender.String(), msg.PayPacketFeeAsync.Relayers), | ||
| } | ||
| return []sdk.Msg{msg}, nil |
There was a problem hiding this comment.
I would suggest keeping the cases here and add more specific error messages than the fallback
There was a problem hiding this comment.
Good point. Added that and tests for it too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.