Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent empty channel version #1697

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Prevent empty channel version #1697

merged 1 commit into from
Nov 10, 2023

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Nov 8, 2023

Resolves #1693

@alpe alpe assigned alpe and unassigned alpe Nov 8, 2023
@alpe alpe added the backport/v0.4x backport patches to sdk47 release branch label Nov 8, 2023
@alpe alpe requested a review from pinosu November 8, 2023 08:25
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #1697 (fc549d4) into main (62d91d9) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1697      +/-   ##
==========================================
+ Coverage   56.80%   56.81%   +0.01%     
==========================================
  Files          62       62              
  Lines        8232     8234       +2     
==========================================
+ Hits         4676     4678       +2     
  Misses       3119     3119              
  Partials      437      437              
Files Coverage Δ
x/wasm/ibc.go 68.71% <100.00%> (+0.35%) ⬆️

Copy link
Contributor

@pinosu pinosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@alpe alpe merged commit 7c8f1e8 into main Nov 10, 2023
8 checks passed
@alpe alpe deleted the 1693_default_version branch November 10, 2023 07:46
alpe added a commit that referenced this pull request Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v0.4x backport patches to sdk47 release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OnChanOpenInit Implementation may not follow IBCModule docs
2 participants