Add grant system tests #1626
Merged
Add grant system tests #1626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1626 +/- ##
==========================================
- Coverage 56.63% 56.60% -0.03%
==========================================
Files 64 64
Lines 8896 8904 +8
==========================================
+ Hits 5038 5040 +2
- Misses 3468 3475 +7
+ Partials 390 389 -1
|
alpe
reviewed
Sep 15, 2023
tests/system/grant_test.go
Outdated
| ) | ||
|
|
||
| //set params | ||
| sut.ModifyGenesisJSON(t, SetCodeUploadPermission(t, "AnyOfAddresses", []string{account1Addr})) |
tests/system/grant_test.go
Outdated
| cli := NewWasmdCLI(t, sut, verbose) | ||
|
|
||
| // add genesis account with some tokens | ||
| account1Addr := cli.AddKey("account1") |
There was a problem hiding this comment.
account1 and 2 are not very verbose. Can think about the role that the address represents?
Maybe something like chain_authorization and dev ?
tests/system/grant_test.go
Outdated
| rsp = cli.CustomCommand("tx", "wasm", "grant-store-code", account2Addr, "*:*", "--from="+account1Addr) | ||
| RequireTxSuccess(t, rsp) | ||
|
|
||
| // address2 store code fails |
There was a problem hiding this comment.
Suggested change
| // address2 store code fails | |
| // address2 store code fails as the address is not in the code-upload accept-list |
tests/system/grant_test.go
Outdated
| rsp = cli.CustomCommand("tx", "wasm", "store", "./testdata/hackatom.wasm.gzip", "--from="+account2Addr, "--gas=1500000", "--fees=2stake") | ||
| RequireTxFailure(t, rsp) | ||
|
|
||
| // create tx |
There was a problem hiding this comment.
Suggested change
| // create tx | |
| // create tx should work for addresses in the accept-list |
tests/system/grant_test.go
Outdated
| err := os.WriteFile(pathToTx, []byte(tx), os.FileMode(0o744)) | ||
| require.NoError(t, err) | ||
|
|
||
| // address2 authz exec store code should succeed |
There was a problem hiding this comment.
Suggested change
| // address2 authz exec store code should succeed | |
| // store code via authz execution uses the given grant and should succeed |
tests/system/genesis_io.go
Outdated
| @@ -31,3 +31,15 @@ func GetGenesisBalance(rawGenesis []byte, addr string) sdk.Coins { | |||
| } | |||
| return r | |||
| } | |||
|
|
|||
| // SetCodeUploadPermission sets the code upload permissions | |||
| func SetCodeUploadPermission(t *testing.T, permission string, addresses []string) GenesisMutator { | |||
There was a problem hiding this comment.
personal preference :-)
Suggested change
| func SetCodeUploadPermission(t *testing.T, permission string, addresses []string) GenesisMutator { | |
| func SetCodeUploadPermission(t *testing.T, permission string, addresses ...string) GenesisMutator { |
* Restructure CLI; fix system test * Review feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.