Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename key store key attribute to be more concrete #1585

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Rename key store key attribute to be more concrete #1585

merged 1 commit into from
Aug 31, 2023

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Aug 30, 2023 •
edited
Loading

Resolves #1182

@alpe
Rename key store key attribute to be more concrete
0d3bfce 
 Please enter the commit message for your changes. Lines starting
@alpe alpe requested a review from pinosu August 30, 2023 13:30
pinosu
pinosu approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@pinosu pinosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Merging #1585 (0d3bfce) into main (78b5af2) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1585   +/-   ##
=======================================
  Coverage   58.22%   58.22%           
=======================================
  Files          64       64           
  Lines        8642     8642           
=======================================
  Hits         5032     5032           
  Misses       3197     3197           
  Partials      413      413
Files Changed Coverage Δ
x/wasm/types/keys.go 60.71% <ø> (ø)
x/wasm/keeper/addresses.go 77.14% <100.00%> (ø)
x/wasm/keeper/genesis.go 88.40% <100.00%> (ø)
x/wasm/keeper/keeper.go 87.36% <100.00%> (ø)

@alpe alpe merged commit 1f49d75 into main Aug 31, 2023
@alpe alpe deleted the rename_key branch August 31, 2023 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinosu pinosu pinosu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename lastIDKey key
2 participants
@alpe @pinosu