Update OnRecvPacket method to panic when an error is returned by the VM #1298

pinosu · 2023-03-27T13:33:40Z

Resolves #1220

by the VM

codecov · 2023-03-27T14:06:57Z

Codecov Report

Merging #1298 (03c264c) into main (5b59886) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1298      +/-   ##
==========================================
+ Coverage   59.46%   59.49%   +0.02%     
==========================================
  Files          57       57              
  Lines        7320     7320              
==========================================
+ Hits         4353     4355       +2     
+ Misses       2653     2652       -1     
+ Partials      314      313       -1

Impacted Files	Coverage Δ
x/wasm/keeper/relay.go	`96.47% <100.00%> (ø)`

... and 1 file with indirect coverage changes

alpe

LGTM 🏄

alpe · 2023-03-29T10:48:23Z

x/wasm/relay_test.go

 		},
 		"error": {
 			contract: &errorReceiverContract{},
 			setupContract: func(t *testing.T, contract wasmtesting.IBCContractCallbacks, chain *wasmibctesting.TestChain) {
 				c := contract.(*errorReceiverContract)
 				c.t = t
 			},
-			expChainABalanceDiff: sdk.ZeroInt(),
-			expChainBBalanceDiff: sdk.ZeroInt(),
+			expChainAPendingSendPackets: 1,


👍 good test

by the VM (cherry picked from commit 5edfd6c) # Conflicts: # x/wasm/keeper/relay.go # x/wasm/relay_test.go

* main: Bump bufbuild/buf-setup-action from 1.15.1 to 1.16.0 Use gov v1 instead of v1beta1 for new proposals (#1269) Update OnRecvPacket method to panic when an error is returned (#1298) Bump actions/checkout from 3.4.0 to 3.5.0 Add source for Wasm magic number

…VM (backport #1298) (#1303) * Update OnRecvPacket method to panic when an error is returned (#1298) by the VM (cherry picked from commit 5edfd6c) # Conflicts: # x/wasm/keeper/relay.go # x/wasm/relay_test.go * fix conflicts --------- Co-authored-by: pinosu <95283998+pinosu@users.noreply.github.com> Co-authored-by: Pino' Surace <pino.surace@live.it>

Update OnRecvPacket method to panic when an error is returned

03c264c

by the VM

pinosu requested a review from alpe March 27, 2023 13:33

alpe approved these changes Mar 29, 2023

View reviewed changes

alpe added the backport/v0.3x Backport patches to sdk45 release branch label Mar 29, 2023

alpe merged commit 5edfd6c into main Mar 29, 2023

mergify bot pushed a commit that referenced this pull request Mar 29, 2023

Update OnRecvPacket method to panic when an error is returned (#1298)

1a1c7ac

by the VM (cherry picked from commit 5edfd6c) # Conflicts: # x/wasm/keeper/relay.go # x/wasm/relay_test.go

mergify bot mentioned this pull request Mar 29, 2023

Update OnRecvPacket method to panic when an error is returned by the VM (backport #1298) #1303

Merged

alpe deleted the 1220-add_panic branch March 31, 2023 08:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update OnRecvPacket method to panic when an error is returned by the VM #1298

Update OnRecvPacket method to panic when an error is returned by the VM #1298

pinosu commented Mar 27, 2023

codecov bot commented Mar 27, 2023 •

edited

Loading

alpe left a comment

alpe Mar 29, 2023

Update OnRecvPacket method to panic when an error is returned by the VM #1298

Update OnRecvPacket method to panic when an error is returned by the VM #1298

Conversation

pinosu commented Mar 27, 2023

codecov bot commented Mar 27, 2023 • edited Loading

Codecov Report

alpe left a comment

Choose a reason for hiding this comment

alpe Mar 29, 2023

Choose a reason for hiding this comment

codecov bot commented Mar 27, 2023 •

edited

Loading