Support msg update params gov proposal #1247

pinosu · 2023-03-08T16:04:44Z

Replace v1beta parameter update model with gov v1 MsgUpdateParams

alpe

Good start! 👍

proto/cosmwasm/wasm/v1/tx.proto

alpe · 2023-03-09T09:52:58Z

proto/cosmwasm/wasm/v1/tx.proto

+  // NOTE: All parameters must be supplied.
+  Params params = 2 [ (gogoproto.nullable) = false ];
+}


x/wasm/keeper/keeper.go

alpe · 2023-03-09T10:13:44Z

x/wasm/keeper/migrations.go

+// version 2 to version 3. Specifically, it takes the parameters that are currently stored
+// and managed by the x/params module and stores them directly into the x/wasm
+// module state.
+func (m Migrator) Migrate2to3(ctx sdk.Context) error {


Good 👁️
Should we move migrations to a new package as the SDK did?

codecov · 2023-03-13T18:03:22Z

Codecov Report

Merging #1247 (9592980) into develop_sdk47 (539c783) will decrease coverage by 0.15%.
The diff coverage is 45.61%.

❗ Current head 9592980 differs from pull request most recent head 5e3bb17. Consider uploading reports for the commit 5e3bb17 to get more accurate results

@@                Coverage Diff                @@
##           develop_sdk47    #1247      +/-   ##
=================================================
- Coverage          59.59%   59.44%   -0.15%     
=================================================
  Files                 54       55       +1     
  Lines               7264     7299      +35     
=================================================
+ Hits                4329     4339      +10     
- Misses              2631     2650      +19     
- Partials             304      310       +6

Impacted Files	Coverage Δ
x/wasm/types/keys.go	`60.71% <ø> (ø)`
x/wasm/types/params.go	`75.00% <ø> (+3.57%)`	⬆️
x/wasm/types/params_legacy.go	`0.00% <0.00%> (ø)`
x/wasm/types/tx.go	`45.64% <0.00%> (-2.61%)`	⬇️
x/wasm/keeper/genesis.go	`88.40% <33.33%> (-2.64%)`	⬇️
x/wasm/keeper/keeper.go	`86.73% <66.66%> (-0.77%)`	⬇️
x/wasm/keeper/msg_server.go	`25.38% <66.66%> (+2.88%)`	⬆️
app/app.go	`86.25% <100.00%> (-0.03%)`	⬇️
x/wasm/keeper/keeper_cgo.go	`91.66% <100.00%> (ø)`
x/wasm/module.go	`38.65% <100.00%> (ø)`
... and 1 more

x/wasm/module.go

x/wasm/simulation/proposals.go

alpe · 2023-03-15T08:17:18Z

app/app.go

@@ -486,6 +489,7 @@ func NewWasmApp(
 	// See: https://docs.cosmos.network/main/modules/gov#proposal-messages
 	govRouter := govv1beta1.NewRouter()
 	govRouter.AddRoute(govtypes.RouterKey, govv1beta1.ProposalHandler).
+		AddRoute(paramproposal.RouterKey, params.NewParamChangeProposalHandler(app.ParamsKeeper)). //This should be removed. It is still in place to avoid failures of modules that have not yet been upgraded.


👍 Thanks for adding this

alpe · 2023-03-15T08:44:44Z

x/wasm/keeper/msg_server.go

+		return nil, err
+	}
+
+	return &types.MsgUpdateParamsResponse{}, nil


* Start cosmos-sdk v0.47 integration (#1136) * Upgrade to sdk v0.47 branch * More integration work * SDK version upgrade; fixes * More fixes * Fixes * Deactivate failing tests * SDK + ibc-go version upgrades * limix gas fix (cherry picked from commit f7f8417) * with valset in bench (cherry picked from commit 35b2a8f) * Revert staking query handler; fix tests * Minor cleanup * Rebased * Address linter issues * Set legacy router proper * Deactivate failing test. Race condition needs to handled in SDK * Address some code smells * Bump sdk version * Use gov v1 internally for votes * Activate test after sdk fix * Add group test * Add config template for wasm fields * Add Rust backtrace flag for more debug output on simulations * Set unique node folder for tests * Revert "Add Rust backtrace flag for more debug output on simulations" This reverts commit 218c3c6. * Simulations * Run also im/export + deterministic sims * Add package prefix to interfaces * Add signer annotation (cosmos/cosmos-sdk#10933), minor cleanup * Bump sdk version * Review comments Co-authored-by: vuong <nguyenvuong1122000@gmail.com> * Bump bufbuild/buf-setup-action from 1.11.0 to 1.12.0 Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action) from 1.11.0 to 1.12.0. - [Release notes](https://github.com/bufbuild/buf-setup-action/releases) - [Commits](bufbuild/buf-setup-action@v1.11.0...v1.12.0) --- updated-dependencies: - dependency-name: bufbuild/buf-setup-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> (cherry picked from commit f490595) * Remove intertx for vanilla ICA * fix msg format in EVENTS.md (cherry picked from commit 38d466a) * Better to sdk coin convertion (#1164) * Better to sdk coin convertion * Review feedback (cherry picked from commit a925a9e) * Disallow only address permission (#1163) * Remove AccessTypeOnlyAddress for store msg * Remove AccessTypeOnlyAddress for update config msg * Review feedback Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com> Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com> (cherry picked from commit 8991633) * Integrate wasmvm v1.2.0 (backport #1161) (#1175) * Integrate wasmvm v1.2.0 (#1161) * Bump wasmvm version * Bump wasm test contracts * Encode weighted votes * Encode instantiate2 * Handle code info query; better wasmvm errors * Fix readme * Make linter happy * add non cgo build * Review comments * Bump wasmvm to release version Co-authored-by: jhernandezb <contact@jhernandez.me> (cherry picked from commit 957b38e) # Conflicts: # x/wasm/keeper/handler_plugin_encoders.go # x/wasm/keeper/handler_plugin_encoders_test.go # x/wasm/keeper/keeper.go # x/wasm/keeper/keeper_test.go * Adress merge conflicts Co-authored-by: Alexander Peters <alpe@users.noreply.github.com> * Bump bufbuild/buf-setup-action from 1.12.0 to 1.13.0 Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action) from 1.12.0 to 1.13.0. - [Release notes](https://github.com/bufbuild/buf-setup-action/releases) - [Commits](bufbuild/buf-setup-action@v1.12.0...v1.13.0) --- updated-dependencies: - dependency-name: bufbuild/buf-setup-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> (cherry picked from commit ffa0e5e) * Emit events for setContractAdmin + setAccessConfig (#1179) (cherry picked from commit c9e7830) * Dependency upgrades (#1172) * Bump sdk version to lastest * Bump ibc-go version to lastest * Remove channel hack * Update to ibc-go v7 + protoVer=0.11.5 * Bump bufbuild/buf-setup-action from 1.13.0 to 1.13.1 Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action) from 1.13.0 to 1.13.1. - [Release notes](https://github.com/bufbuild/buf-setup-action/releases) - [Commits](bufbuild/buf-setup-action@v1.13.0...v1.13.1) --- updated-dependencies: - dependency-name: bufbuild/buf-setup-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> (cherry picked from commit de27e7f) * Fix typos (backport #1185) (#1194) * Fix typos (cherry picked from commit c88b819) # Conflicts: # proto/cosmwasm/wasm/v1/tx.proto * Fix merge conflict --------- Co-authored-by: Alex Peters <alpe@users.noreply.github.com> * Bump bufbuild/buf-setup-action from 1.13.1 to 1.14.0 (#1200) Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action) from 1.13.1 to 1.14.0. - [Release notes](https://github.com/bufbuild/buf-setup-action/releases) - [Commits](bufbuild/buf-setup-action@v1.13.1...v1.14.0) --- updated-dependencies: - dependency-name: bufbuild/buf-setup-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit f3fc31c) * list-contract-by-code bugfix (cherry picked from commit 2ccffed) * fix: stargate querier does not reset the state (cherry picked from commit fd03235) * test: add unit test (cherry picked from commit 6d8018a) * Add Windows client support (#1197) * Add Windows client support * Separate server and windows client --------- Co-authored-by: Alex Peters <alpe@users.noreply.github.com> (cherry picked from commit 8a20779) * Bump bufbuild/buf-setup-action from 1.14.0 to 1.15.0 Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action) from 1.14.0 to 1.15.0. - [Release notes](https://github.com/bufbuild/buf-setup-action/releases) - [Commits](bufbuild/buf-setup-action@v1.14.0...v1.15.0) --- updated-dependencies: - dependency-name: bufbuild/buf-setup-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> (cherry picked from commit e5fab3d) * Rename windows client binary (cherry picked from commit de09c7f) * Return IBC packet sequence number (backport #1225) (#1233) * Return IBC packet sequence number (#1225) * Return IBC packet sequence number * Fix review feedbacks * Remove names to return values in DispatchMsg method * Fix comments (cherry picked from commit 4f1c57f) # Conflicts: # x/wasm/keeper/handler_plugin.go * Fix merge conflict --------- Co-authored-by: pinosu <95283998+pinosu@users.noreply.github.com> Co-authored-by: Alex Peters <alpe@users.noreply.github.com> * Test rust panic for regression (cherry picked from commit a52e604) * Fix client checksum verification (#1234) * Fix client checksum verification * Review comments (cherry picked from commit 1a8019b) # Conflicts: # x/wasm/client/cli/gov_tx.go * Fix merge conflict * Fix linters * Configure sonarcloud analysis (cherry picked from commit 85cf161) * Bump bufbuild/buf-setup-action from 1.15.0 to 1.15.1 Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action) from 1.15.0 to 1.15.1. - [Release notes](https://github.com/bufbuild/buf-setup-action/releases) - [Commits](bufbuild/buf-setup-action@v1.15.0...v1.15.1) --- updated-dependencies: - dependency-name: bufbuild/buf-setup-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> (cherry picked from commit 730ea5a) * Make `CaptureIbcEvents` in ibctesting public. Before this change, it wasn't possible to implement the `chain.SendMsgs` method without [copying](https://github.com/public-awesome/ics721/blob/main/e2e/suite_helpers.go#L81-L98) them over. (cherry picked from commit b64fa07) * Upgrade to wasmvm 1.2.1 (backport #1245) (#1254) * Upgrade to wasmvm 1.2.1 (#1245) * Use wasmvm store adapter * Bump wasmvm to v1.2.1 (cherry picked from commit 850f901) # Conflicts: # go.mod # go.sum # x/wasm/keeper/keeper.go * Resolve conflicts --------- Co-authored-by: Alexander Peters <alpe@users.noreply.github.com> * WIP All cometbft (#1244) * Dep upgrade; use CometBft * Remove duplicte message events * Add changelog for v0.31.0 (#1188) * Start changelog for v0.31.0 * Add ICA upgrade * Add proto version link to buf.build * Update changelog (#1239) * Update changelog * Update changelog with latest changes * Set release date --------- Co-authored-by: pinosu <95283998+pinosu@users.noreply.github.com> (cherry picked from commit bc0e817) * Remove new message type event * Support msg update params gov proposal (#1247) * Add MsgUpdateParams support * Implement UpdateParams msg * Fix test UpdateParams * Add migration test * Fix * Fix lint issues * Revert changes according to review feedback * Remove more x/params dependencies * Remove x/params from genesis test * Formatting * Restore old changes * fix lint * Fix tests and restructure migrations * Rename alias for convention --------- Co-authored-by: Alex Peters <alpe@users.noreply.github.com> * Fix test data generator (#1263) * linting 47 pr (#1261) * lint cosmwasm for sdk 47 * fix * remove setGenesis * remove additional unused functions * pass tests * use SDK's errors module * unecessary conversions * unnecessary conversions * remove unneeded event manager * complete linting of tests for 47 * add test for reimportation * check errors * Update x/wasm/keeper/proposal_integration_test.go Co-authored-by: Alexander Peters <alpe@users.noreply.github.com> * apply suggestion * suggestions * lints * don't return error in when making new transactions * no todo's in the code * Fix test data generator * Update x/wasm/types/genesis_test.go Co-authored-by: Alexander Peters <alpe@users.noreply.github.com> * use the full string invalid address (2 words) always --------- Co-authored-by: Alexander Peters <alpe@users.noreply.github.com> * Regenerate from proto; remove dead code; polish code * Set SDK version to v0.47x.0 (#1262) * Set SDK version to v0.47x.0 * Set chainID * Minor updates * Set chainID for simulations * Buf mod update * Use sdk tag instead of hash in buf * Bump ibc-go to v7.0.0 * faddat/re merge main (#1274) undefined --------- Co-authored-by: vuong <nguyenvuong1122000@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: llllllluc <58892938+llllllluc@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Gjermund Garaba <gjermund@garaba.net> Co-authored-by: Nikhil Suri <nikhilsuri@comcast.net> Co-authored-by: Paul <p22626262@gmail.com> Co-authored-by: pinosu <95283998+pinosu@users.noreply.github.com> Co-authored-by: ekez <zekemedley@gmail.com> Co-authored-by: Jacob Gadikian <jacobgadikian@gmail.com>

alpe reviewed Mar 9, 2023

View reviewed changes

pinosu force-pushed the 1243-support_msg_update_params_gov_proposal branch from e0a720a to 510d0ac Compare March 9, 2023 13:15

alpe force-pushed the all_cometbft branch 2 times, most recently from 3c1b56a to a2d5e7b Compare March 10, 2023 11:16

pinosu force-pushed the 1243-support_msg_update_params_gov_proposal branch from 088d6ae to 02224ff Compare March 13, 2023 08:28

pinosu changed the base branch from all_cometbft to develop_sdk47 March 13, 2023 08:30

alpe reviewed Mar 14, 2023

View reviewed changes

x/wasm/module.go Show resolved Hide resolved

x/wasm/simulation/proposals.go Show resolved Hide resolved

pinosu and others added 10 commits March 14, 2023 15:07

Add MsgUpdateParams support

45f9350

Implement UpdateParams msg

0120ec2

Fix test UpdateParams

b48c263

Add migration test

d7f9a26

Fix

4bb81db

Fix lint issues

8365c2c

Revert changes according to review feedback

e409827

Remove more x/params dependencies

6fc9ef5

Remove x/params from genesis test

455e230

Formatting

9592980

alpe force-pushed the 1243-support_msg_update_params_gov_proposal branch from f4e0ce0 to 9592980 Compare March 14, 2023 14:18

alpe changed the title ~~[WIP] support msg update params gov proposal~~ Support msg update params gov proposal Mar 14, 2023

Restore old changes

f6260c9

pinosu marked this pull request as ready for review March 14, 2023 19:48

pinosu and others added 3 commits March 15, 2023 10:03

fix lint

f58e01b

Fix tests and restructure migrations

08d9d5d

Rename alias for convention

5e3bb17

alpe approved these changes Mar 15, 2023

View reviewed changes

alpe merged commit d648261 into develop_sdk47 Mar 15, 2023

alpe deleted the 1243-support_msg_update_params_gov_proposal branch March 15, 2023 11:15

alpe mentioned this pull request Mar 16, 2023

Support MsgUpdateParams gov proposal (47) #1243

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support msg update params gov proposal #1247

Support msg update params gov proposal #1247

pinosu commented Mar 8, 2023 •

edited by alpe

Loading

alpe left a comment

alpe Mar 9, 2023

alpe Mar 9, 2023

codecov bot commented Mar 13, 2023 •

edited

Loading

alpe Mar 15, 2023

alpe Mar 15, 2023

Support msg update params gov proposal #1247

Support msg update params gov proposal #1247

Conversation

pinosu commented Mar 8, 2023 • edited by alpe Loading

alpe left a comment

Choose a reason for hiding this comment

alpe Mar 9, 2023

Choose a reason for hiding this comment

alpe Mar 9, 2023

Choose a reason for hiding this comment

codecov bot commented Mar 13, 2023 • edited Loading

Codecov Report

alpe Mar 15, 2023

Choose a reason for hiding this comment

alpe Mar 15, 2023

Choose a reason for hiding this comment

pinosu commented Mar 8, 2023 •

edited by alpe

Loading

codecov bot commented Mar 13, 2023 •

edited

Loading