fix: sort coins in ConvertWasmCoinsToSdkCoins
#1117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## main #1117 +/- ##
==========================================
- Coverage 59.95% 59.92% -0.03%
==========================================
Files 54 54
Lines 7406 7407 +1
==========================================
- Hits 4440 4439 -1
- Misses 2641 2642 +1
- Partials 325 326 +1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When sending e.g.
BankMsg::Sendfrom a contract, it appears that currently the coins inamountparameter need to be sorted. This is inconvenient as contracts need to add additional logic to sort coins before sending them. This PR simply sorts them instead in wasmd when converting them into SDK Coins.