Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix genesis message tooling #1002

Merged
merged 1 commit into from
Sep 19, 2022
Merged

Fix genesis message tooling #1002

merged 1 commit into from
Sep 19, 2022

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Sep 14, 2022

The addressed built for genesis message tooling calculate the wrong hash as the code is zipped

@alpe alpe requested a review from pinosu September 14, 2022 10:36
@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Merging #1002 (0b400d6) into main (8fc9855) will decrease coverage by 0.00%.
The diff coverage is 28.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1002      +/-   ##
==========================================
- Coverage   60.34%   60.33%   -0.01%     
==========================================
  Files          52       52              
  Lines        6430     6436       +6     
==========================================
+ Hits         3880     3883       +3     
- Misses       2263     2266       +3     
  Partials      287      287              
Impacted Files Coverage Δ
x/wasm/client/cli/genesis_msg.go 68.97% <28.57%> (-1.06%) ⬇️
x/wasm/keeper/keeper.go 87.87% <0.00%> (+0.31%) ⬆️

Copy link
Contributor

@pinosu pinosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good!
Could you add some tests for the function GetAllCodes?

@alpe
Copy link
Contributor Author

alpe commented Sep 14, 2022

Could you add some tests for the function GetAllCodes?

Good call but I would love to remove the whole section instead, see #987 . This is a minimal fix as system tests in tgrade covered this: confio/tgrade#451

Copy link
Contributor

@pinosu pinosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. LGTM 👍

@alpe alpe merged commit 9ec8091 into main Sep 19, 2022
@alpe alpe deleted the 942_fix_genmsg branch September 19, 2022 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants