Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to cosmos-sdk 0.38 #15

Closed
7 tasks
ethanfrey opened this issue Jan 10, 2020 · 3 comments · Fixed by #44
Closed
7 tasks

Upgrade to cosmos-sdk 0.38 #15

ethanfrey opened this issue Jan 10, 2020 · 3 comments · Fixed by #44
Assignees

Comments

@ethanfrey
Copy link
Member

Summary

A new stable release should be out in the next few days. It's much nice to base on that, then on a moving master branch. It also allows other projects to re-use the x/wasmd module much easier.

Proposal

  • Pull in changes to github.com/cosmos/gaia since we forked off (That is, anything after d6dfa141e2ae38a1ff9f53fca8078c0822671b95, or about 20 commit).
  • Update the requirements to cosmos-sdk:0.38 (if not already done by the above)
  • Update x/wasmd as needed for compatibilty

This should also include adding the upgrade module to the core app, which seems to have been done in cosmos/gaia@9823769

Please note that pulling in changes is a bit tricky as we are not a proper fork, but have changed all import paths (so wasmd can be used properly as a stand-alone program). This will likely involve more manual work than a simple merge and conflict clean-up (although you can try that first). I think cherry-picking commits one by one may end up the easier. Note that many commits seem minor requirement upgrades and doc improvements, so the number with conflicts should be relatively limited. Here is an idea:

git checkout -b upgrade
git remote add upstream https://github.com/cosmos/gaia
git fetch upstream
git merge upstream/master

but that produces 31 file conflicts, although 22 are in markdown files


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@sunnya97
Copy link
Contributor

I've created a version that is upgraded to the latest version of the master branch.

https://github.com/sikkatech/wasmd/tree/sdk-bump-version

Will add as PR once upgraded to official 0.38 and after #6 is merged (is branched off of that).

@ethanfrey
Copy link
Member Author

Thank you @sunnya97 👍

@ethanfrey
Copy link
Member Author

@sunnya97 They are working on rc1 for 0.38.

I merged a bunch in the meantime (esp. 0.6.3 cosmwasm with an overhaul on errors usage in x/wasmd).

It would be great if you could rebase on current master and do the update. Note, I don't just want to update the dep, but also merge in any relevant changes to gaia. In particular, they added the upgrade module, which I want, and seem to have done a number of other adjustments in app. We can remove many of the docs from gaia, but I want the app code to stay in sync as much as possible

@ethanfrey ethanfrey mentioned this issue Jan 21, 2020
4 tasks
@ethanfrey ethanfrey assigned ethanfrey and unassigned sunnya97 Jan 23, 2020
@ethanfrey ethanfrey mentioned this issue Jan 23, 2020
5 tasks
@sunnya97 sunnya97 mentioned this issue Jan 23, 2020
5 tasks
NoahSaso pushed a commit to NoahSaso/wasmd that referenced this issue Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants