Skip to content

Commit

Permalink
Integrate PR review
Browse files Browse the repository at this point in the history
  • Loading branch information
ethanfrey committed Mar 9, 2021
1 parent 91ad768 commit 9ce450a
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions x/wasm/internal/keeper/query_plugins.go
Original file line number Diff line number Diff line change
Expand Up @@ -173,9 +173,6 @@ func IBCQuerier(wasm *Keeper, channelKeeper types.ChannelKeeper) func(ctx sdk.Co
}
return json.Marshal(res)
}
// I just discovered we cannot query by port (how odd since they store it like this)
// Anyway, I will allow Port as an optional filter
// TODO: let's revisit this query (if needed, if we should change it)
if request.ListChannels != nil {
portID := request.ListChannels.PortID
var channels wasmvmtypes.IBCEndpoints
Expand All @@ -196,7 +193,6 @@ func IBCQuerier(wasm *Keeper, channelKeeper types.ChannelKeeper) func(ctx sdk.Co
}
if request.Channel != nil {
channelID := request.Channel.ChannelID
_ = channelID
portID := request.Channel.PortID
if portID == "" {
contractInfo := wasm.GetContractInfo(ctx, caller)
Expand All @@ -216,7 +212,7 @@ func IBCQuerier(wasm *Keeper, channelKeeper types.ChannelKeeper) func(ctx sdk.Co
},
Order: got.Ordering.String(),
Version: got.Version,
CounterpartyVersion: got.Version, // FIXME: maybe we change the type? This data is not stored AFAIK
CounterpartyVersion: "",
ConnectionID: got.ConnectionHops[0],
}
}
Expand Down

0 comments on commit 9ce450a

Please sign in to comment.