-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add_tokens() uses generic coin trait #93
Conversation
b466f94
to
144e3c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I see you desire to simplify one function, this adds quite a bit of cognitive complexity to the whole system. Coins and Cw20Coins should be easy to pick up for new coders (as the basis of much other contracts). I would not go this approach.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0fef0b6
to
ede00cf
Compare
Yes, this was just an idea, and I wanted to hear your opinion about it. That's why I put it in a different PR. I'm OK with not doing it, and I agree it adds unnecessary complexity. |
Simplifies
add_tokens()
by usingGenericCoin
.Requires #533 in cosmwasm-plus.