Validate allowance expiration #792
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
uint
approved these changes
Sep 5, 2022
| let mut val = allow.unwrap_or_default(); | ||
| if let Some(exp) = expires { | ||
| if exp.is_expired(&env.block) { |
There was a problem hiding this comment.
You found this helper instead of writing the check yourself. Nice!
| let mut val = allow.unwrap_or_default(); | ||
| if let Some(exp) = expires { | ||
| if exp.is_expired(&env.block) { | ||
| return Err(ContractError::Expired {}); |
There was a problem hiding this comment.
More a suggestion than a blocker. I think what we want is more a validation error, just to be clearer to the user/consumer. The problem isn't that an existing allowance is expired, the problem is the user is trying to create/modify an allowance so that it expires in the past.
I'd add a new error variant here:
https://github.com/CosmWasm/cw-plus/blob/main/contracts/cw20-base/src/error.rs
|
For some reason CircleCI is not picking up this branch. Let's figure that out... |
|
Closing this, as it is a part of #793 and the ci picked that one up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #628
Adds a check for valid expiration when increasing or decreasing allowance.
Also had to change some of the tests because they were creating expired allowances to test the expiration checks of the other message handlers.