Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose cw-multi-test FailingModule #773

Merged
merged 2 commits into from
Aug 8, 2022

Conversation

dadamu
Copy link
Contributor

@dadamu dadamu commented Aug 8, 2022

Make FailingModule in cw-multi-test public would be useful to build a custom failing module for the custom chain, say:

pub trait DesmosModule: Module<ExecT = DesmosMsg, QueryT = DesmosQuery, SudoT = Empty> {}

impl DesmosModule for DesmosKeeper {}
impl DesmosModule for FailingModule<DesmosMsg, DesmosQuery, Empty> {}

@CLAassistant
Copy link

CLAassistant commented Aug 8, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@ueco-jb ueco-jb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ueco-jb ueco-jb merged commit fc79cdd into CosmWasm:main Aug 8, 2022
@dadamu dadamu deleted the paul/expose-failing-module branch August 9, 2022 16:19
mergify bot pushed a commit to desmos-labs/contracts-bindings that referenced this pull request Sep 16, 2022
This PR intends to give a way to build custom `DesmosKeeper` for tests by having a new trait `DesmosModule`.

```rust
pub struct CustomDesmosKeeper {}
impl DesmosModule for CustomDesmosKeeper {
   // custom handle functions
}

#[test]
fn test_something() -> {
    let mut app = custom_desmos_app(CustomDesmosKeeper{}, |_, _, _| {});
    // test with custom mock app ...
}
```

After CosmWasm/cw-plus#773 is released, it can be merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants