Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add single validator query #879

Merged
merged 3 commits into from
Apr 15, 2021
Merged

Add single validator query #879

merged 3 commits into from
Apr 15, 2021

Conversation

webmaster128
Copy link
Member

@webmaster128 webmaster128 commented Apr 14, 2021 •
edited
Loading

Closes #819

  • Implementation
  • CHANGELOG entry

@webmaster128 webmaster128 requested a review from ethanfrey April 14, 2021 13:25
@webmaster128 webmaster128 mentioned this pull request Apr 14, 2021
Closed
ethanfrey
ethanfrey approved these changes Apr 14, 2021
View reviewed changes
Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice stuff and good addition.
Just noticed no staking feature gating on the StakingQuery

CHANGELOG.md Show resolved Hide resolved
contracts/staking/src/contract.rs Show resolved Hide resolved
packages/std/src/mock.rs Show resolved Hide resolved
packages/std/src/query.rs Outdated Show resolved Hide resolved
packages/std/src/query.rs Outdated Show resolved Hide resolved
packages/std/src/traits.rs Show resolved Hide resolved
@webmaster128 webmaster128 added the automerge See mergify.io label Apr 15, 2021
@webmaster128 webmaster128 merged commit 5b63cf6 into main Apr 15, 2021
@webmaster128 webmaster128 deleted the query_validator branch April 15, 2021 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanfrey ethanfrey ethanfrey approved these changes

Assignees
No one assigned
Labels
automerge See mergify.io
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How about adding single validator staking query
2 participants
@webmaster128 @ethanfrey