Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move cosmwasm into packages/std #167

Merged
merged 7 commits into from
Mar 20, 2020
Merged

Move cosmwasm into packages/std #167

merged 7 commits into from
Mar 20, 2020

Conversation

webmaster128
Copy link
Member

First part of #165

Let's see what CI says.

I'm also thinking about renaming ./lib to ./packages or ./projects, but I'm a bit unsure what the best name for workspace members is (members, package and project are used in https://doc.rust-lang.org/book/ch14-03-cargo-workspaces.html)

@webmaster128
Copy link
Member Author

I'm also thinking about renaming ./lib to ./packages or ./projects, but I'm a bit unsure what the best name for workspace members is (members, package and project are used in https://doc.rust-lang.org/book/ch14-03-cargo-workspaces.html)

In recent versions of cargo, it is now called package

$ cargo new adder
// ...
     Created binary (application) `adder` package

@webmaster128 webmaster128 marked this pull request as ready for review March 20, 2020 08:35
@webmaster128 webmaster128 requested a review from ethanfrey March 20, 2020 08:35
@webmaster128 webmaster128 changed the title Move package cosmwasm into lib/std Move cosmwasm into packages/std Mar 20, 2020
Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, if the CI says it works, then I am happu

Cargo.toml Outdated
[features]
backtraces = ["snafu/backtraces"]
members = [
"packages/std",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can use packages/* which will auto-add any new package

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jap, better

@@ -2,8 +2,8 @@

[![CircleCI](https://circleci.com/gh/CosmWasm/cosmwasm/tree/master.svg?style=shield)](https://circleci.com/gh/CosmWasm/cosmwasm/tree/master)
[![Docs](https://docs.rs/cosmwasm/badge.svg)](https://docs.rs/cosmwasm)
[![crates.io](https://img.shields.io/crates/v/cosmwasm.svg)](https://crates.io/crates/cosmwasm)

[![cosmwasm on crates.io](https://img.shields.io/crates/v/cosmwasm.svg)](https://crates.io/crates/cosmwasm)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@webmaster128 webmaster128 merged commit 1a84451 into master Mar 20, 2020
@webmaster128 webmaster128 deleted the move-sdt branch March 20, 2020 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants