Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename plugin #38

Closed
chonton opened this issue Feb 23, 2020 · 1 comment · Fixed by #39
Closed

Rename plugin #38

chonton opened this issue Feb 23, 2020 · 1 comment · Fixed by #39

Comments

@chonton
Copy link
Contributor

chonton commented Feb 23, 2020 •
edited
Loading

According to Maven plugin guide, prefixing a plugin with "maven-" is discouraged and may be in violation of Apache trademarks.

Please rename the plugin. Perhaps "pre-commit-maven-plugin"?
@reda-alaoui
Copy link
Member

Oh I didn't know that.

In that case, let's rename it git-code-format-maven-plugin.

@chonton chonton mentioned this issue Feb 25, 2020
Merged
reda-alaoui pushed a commit that referenced this issue Feb 25, 2020
@chonton
Rename plugin: maven-git-code-format -> git-code-format-maven-plugin (#…
fba629a 
…39)

Closes: #38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename plugin: maven-git-code-format -> git-code-format-maven-plugin
2 participants
@chonton @reda-alaoui