Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inaccurate parsing of headers. #5

Closed
ben-crowhurst opened this issue Jun 22, 2015 · 1 comment
Closed

Inaccurate parsing of headers. #5

ben-crowhurst opened this issue Jun 22, 2015 · 1 comment
Assignees
@ben-crowhurst
Labels
bug

Comments

@ben-crowhurst
Copy link
Member

This (^(.*): *(.*)\\s*$) does not look like correct headers handling, for instance try to parse User-Agent: Mozilla:4.0. Are you aware of RFC 7230 to speak about compliance?
@ben-crowhurst
Copy link
Member Author

With a brief test this seems better suited for the task ([^:.]*): *(.*)\s*. Further testing necessary.

@ben-crowhurst ben-crowhurst self-assigned this Jun 22, 2015
ben-crowhurst added a commit that referenced this issue Jun 23, 2015
@ben-crowhurst
resolved issue #5
876ada5
@omidnikta omidnikta mentioned this issue Nov 30, 2015
Closed
@greenday9 greenday9 mentioned this issue Aug 9, 2016
Closed
This was referenced Sep 28, 2017
Closed
Closed
@zhanb zhanb mentioned this issue Oct 11, 2018
Closed
@zhanb zhanb mentioned this issue Nov 16, 2018
Closed
@zhanb zhanb mentioned this issue Jun 30, 2019
Closed
@salmangano salmangano mentioned this issue Jul 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ben-crowhurst ben-crowhurst

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ben-crowhurst