Added TypeScript type definitions #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intrueder
suggested changes
Apr 23, 2021
index.d.ts
Outdated
| capsMask: number | ||
| ledsCount: number | ||
| channels: { | ||
| channelsCount: number |
There was a problem hiding this comment.
This does not look complete
There was a problem hiding this comment.
In the CUE SDK documentation is a property deviceId for the CorsairDeviceInfo but I didn't manage to get this with any of my devices. Does this property really exist?
There was a problem hiding this comment.
I'll create an issue for this, js wrapper does not have CorsairDeviceInfo.deviceId property but it does exist in the CUESDK.
There was a problem hiding this comment.
#15 will fix it once this PR is merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added an index.d.ts file.
This allows to get intellisense support for regular usage with JavaScript and to use this library with TypeScript using the type definitions.