Grafana 7: Exporter panel doesn't see datasource #40 #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rozetko
reviewed
Sep 17, 2020
| @@ -122,6 +122,12 @@ class Ctrl extends PanelCtrl { | |||
| } | |||
| } | |||
|
|
|||
| private async _getDefaultDatasource() { | |||
rozetko
reviewed
Sep 17, 2020
src/module.ts
Outdated
| let datasource = await this._getDatasourceByName(datasourceName); | ||
| this._datasourceTypes[panel.id] = datasource.type; | ||
|
|
||
| if (!panel.datasource) { |
There was a problem hiding this comment.
let's be specific here, e.g.: panel.datasource === undefined or panel.datasouce === null
rozetko
reviewed
Sep 17, 2020
src/module.ts
Outdated
| @@ -175,12 +181,19 @@ class Ctrl extends PanelCtrl { | |||
| private async _getGrafanaAPIInfo() { | |||
| this._user = await this._getCurrentUser(); | |||
| for(let panel of this.panels) { | |||
| let datasourceName = panel.datasource; | |||
| if(!datasourceName) { | |||
| if (panel.type === 'corpglory-data-exporter-panel') { | |||
There was a problem hiding this comment.
Suggested change
| if (panel.type === 'corpglory-data-exporter-panel') { | |
| if(panel.type === 'corpglory-data-exporter-panel') { |
we don't add space before brackets in our codestyle
rozetko
reviewed
Sep 17, 2020
src/module.ts
Outdated
| let datasource = await this._getDatasourceByName(datasourceName); | ||
| this._datasourceTypes[panel.id] = datasource.type; | ||
|
|
||
| if (!panel.datasource) { |
There was a problem hiding this comment.
Suggested change
| if (!panel.datasource) { | |
| if(!panel.datasource) { |
we don't add space before brackets in our codestyle
Fixed code style
|
will be recreated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #40
Probem:
We don`t see default datasource in the exporter panel
Solution:
Send an additional request to get all datasources and find one with the
isDefault = trueChanges:
Added
_getDefaultDatasourcefunctonChangaed
_getGrafanaAPIInfofunction