Change rendered fields #5 #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rozetko
reviewed
Sep 21, 2018
src/partials/module.html
Outdated
| @@ -55,8 +49,7 @@ | |||
| ng-repeat="target in panel.targets" | |||
| ng-if="ctrl.showRows[panel.id]" | |||
| > | |||
| <td></td> | |||
| <td></td> | |||
| <td>{{ panel.title }}</td> | |||
There was a problem hiding this comment.
Seems like it would look better without repeating panel title in every row :)
rozetko
requested changes
Sep 21, 2018
src/partials/module.html
Outdated
| @@ -67,7 +60,6 @@ | |||
| {{ target.query }} | |||
| </td> | |||
| <td ng-if="target.query === undefined"> | |||
There was a problem hiding this comment.
Are you sure we still need this? Because we don't have query in table anymore
There was a problem hiding this comment.
Guess, there are different amount of columns in header and inside the table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5
Minor table fixes.
Button not clicked:
Button clicked:
