Feat(contacted people) import data from excel #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sandymash
commented
Oct 8, 2020
sandymash
commented
- added import from excel button to contact events to enable bulk insert of contacted people
- added contact event id to contacted person query
- added custom swal comp to be used generically (closes Generic Swal #234)
- deleted unused flights route
- added import from excel button to contact events to enable bulk insert of contacted people - added contact event id to contacted person query - added custom swal comp to be used generically - deleted unused flights route
- fix cant reach contact field name - remove unused columns - handle null foreign keys
- fix imports & remove logs - changed comp name & hierarchy
- server - remove logs and comments
added 3 commits
October 8, 2020 13:17
- handle emptry rows with columns that dont belong to the data
roymaniv
reviewed
Oct 8, 2020
...Management/InteractionsTab/ContactDateCard/InteractionCard/ExcelUploader/ContactUploader.tsx
Outdated
Show resolved
Hide resolved
roymaniv
reviewed
Oct 8, 2020
...ionForm/TabManagement/InteractionsTab/ContactDateCard/InteractionCard/ExcelUploader/enums.ts
Outdated
Show resolved
Hide resolved
roymaniv
previously approved these changes
Oct 11, 2020
daniel7764
previously approved these changes
Oct 11, 2020
RoeiRom
requested changes
Oct 11, 2020
.../Content/InvestigationForm/TabManagement/InteractionsTab/ContactDateCard/ContactDateCard.tsx
Outdated
Show resolved
Hide resolved
...bManagement/InteractionsTab/ContactDateCard/InteractionCard/ExcelUploader/useContactExcel.ts
Outdated
Show resolved
Hide resolved
...gationForm/TabManagement/InteractionsTab/ContactDateCard/InteractionCard/InteractionCard.tsx
Show resolved
Hide resolved
RoeiRom
previously approved these changes
Oct 11, 2020
RoeiRom
approved these changes
Oct 11, 2020
NaamanTsur
approved these changes
Oct 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.