Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable go.work in root of the repo #68

Merged
merged 7 commits into from
Dec 18, 2023
Merged

enable go.work in root of the repo #68

merged 7 commits into from
Dec 18, 2023

Conversation

miladz68
Copy link
Contributor

@miladz68 miladz68 commented Dec 15, 2023

Description

This PR adds go.work and go.work.sum to the root of the repository.

Reviewers checklist:

  • Try to write more meaningful comments with clear actions to be taken.
  • Nit-picking should be unblocking. Focus on core issues.

Authors checklist

  • Provide a concise and meaningful description
  • Review the code yourself first, before making the PR.
  • Annotate your PR in places that require explanation.
  • Think and try to split the PR to smaller PR if it is big.

This change is Reviewable

@miladz68 miladz68 requested a review from a team as a code owner December 15, 2023 07:16
@miladz68 miladz68 requested review from dzmitryhil, ysv and wojtek-coreum and removed request for a team December 15, 2023 07:16
Copy link
Contributor

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI tests are failed

Reviewable status: 0 of 19 files reviewed, all discussions resolved (waiting on @wojtek-coreum and @ysv)

dzmitryhil
dzmitryhil previously approved these changes Dec 15, 2023
Copy link
Contributor

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 19 of 19 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @wojtek-coreum and @ysv)

wojtek-coreum
wojtek-coreum previously approved these changes Dec 15, 2023
Copy link
Collaborator

@wojtek-coreum wojtek-coreum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 19 of 19 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @miladz68 and @ysv)


integration-tests/go.mod line 32 at r1 (raw file):

)

require github.com/coinbase/rosetta-sdk-go/types v1.0.0 // indirect

minor: merge it into the block below


relayer/go.mod line 38 at r1 (raw file):

)

require github.com/coinbase/rosetta-sdk-go/types v1.0.0 // indirect

minor: same thing

@miladz68 miladz68 dismissed stale reviews from wojtek-coreum and dzmitryhil via 73432bc December 15, 2023 12:18
wojtek-coreum
wojtek-coreum previously approved these changes Dec 15, 2023
Copy link
Collaborator

@wojtek-coreum wojtek-coreum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @miladz68 and @ysv)

wojtek-coreum
wojtek-coreum previously approved these changes Dec 15, 2023
Copy link
Collaborator

@wojtek-coreum wojtek-coreum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r3, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @miladz68 and @ysv)

wojtek-coreum
wojtek-coreum previously approved these changes Dec 18, 2023
Copy link
Collaborator

@wojtek-coreum wojtek-coreum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ysv)

Copy link
Collaborator

@wojtek-coreum wojtek-coreum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r5, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ysv)

Copy link
Contributor

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 4 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ysv)

@miladz68 miladz68 merged commit a8a8779 into master Dec 18, 2023
4 checks passed
@miladz68 miladz68 deleted the milad/enable-go-work branch December 18, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants