Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contract: Transfer fees for XRPL originated tokens that include them #66

Closed
wants to merge 3 commits into from
Closed

Contract: Transfer fees for XRPL originated tokens that include them #66

wants to merge 3 commits into from

Conversation

keyleu
Copy link
Collaborator

@keyleu keyleu commented Dec 14, 2023 •
edited
Loading

Description

  • Implemented Transfer Fees for XRPL originated tokens that apply them.
  • Modified truncation to be done after applying all fees (for all transfers) because XRPL doesn't support amounts like 1e17+1 so we must truncate in the last step.

Reviewers checklist:

  • Try to write more meaningful comments with clear actions to be taken.
  • Nit-picking should be unblocking. Focus on core issues.

Authors checklist

  • Provide a concise and meaningful description
  • Review the code yourself first, before making the PR.
  • Annotate your PR in places that require explanation.
  • Think and try to split the PR to smaller PR if it is big.

This change is Reviewable

@keyleu keyleu requested a review from a team as a code owner December 14, 2023 10:58
@keyleu keyleu requested review from dzmitryhil, miladz68, ysv and wojtek-coreum and removed request for a team December 14, 2023 10:58
@keyleu keyleu closed this Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzmitryhil dzmitryhil Awaiting requested review from dzmitryhil dzmitryhil is a code owner automatically assigned from CoreumFoundation/team-blockchain

@miladz68 miladz68 Awaiting requested review from miladz68 miladz68 is a code owner automatically assigned from CoreumFoundation/team-blockchain

@ysv ysv Awaiting requested review from ysv ysv is a code owner automatically assigned from CoreumFoundation/team-blockchain

@wojtek-coreum wojtek-coreum Awaiting requested review from wojtek-coreum wojtek-coreum is a code owner automatically assigned from CoreumFoundation/team-blockchain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@keyleu