Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relayer: Recover XRPL originated token registration #53

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

dzmitryhil
Copy link
Contributor

@dzmitryhil dzmitryhil commented Nov 29, 2023

Description

  • Add contract client integration tests
  • Add relayer (runners) integration test
  • Add non-existing accounts error handing for the xrpl_tx_submitter

Reviewers checklist:

  • Try to write more meaningful comments with clear actions to be taken.
  • Nit-picking should be unblocking. Focus on core issues.

Authors checklist

  • Provide a concise and meaningful description
  • Review the code yourself first, before making the PR.
  • Annotate your PR in places that require explanation.
  • Think and try to split the PR to smaller PR if it is big.

This change is Reviewable

* Add contract client integration tests
* Add relayer (runners) integration test
* Add non-existing accounts error handing for the xrpl_tx_submitter
@dzmitryhil dzmitryhil requested a review from a team as a code owner November 29, 2023 12:44
@dzmitryhil dzmitryhil requested review from miladz68, ysv and wojtek-coreum and removed request for a team November 29, 2023 12:44
Copy link
Contributor

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @wojtek-coreum and @ysv)

Copy link
Collaborator

@ysv ysv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @dzmitryhil and @wojtek-coreum)


integration-tests/coreum/contract_client_test.go line 2244 at r1 (raw file):

	// try to recover the token with the unexpected current state
	_, err = contractClient.RecoverXRPLTokenRegistration(ctx, owner, issuer, currency)
	require.True(t, coreum.IsXRPLTokenNotInactiveError(err), err)

xrpl Token Not Inactive so is it active or not ?
I guess it is double negation done by mistake

either xrplTokenInactive or xrplTokenNotActive


integration-tests/coreum/contract_client_test.go line 2338 at r1 (raw file):

	require.Equal(t, coreum.TokenStateEnabled, registeredXRPLToken.State)
}

nit: this file is getting too big
Shall we split it into multiple by business logic or flows e.g: token registration, token send, contract administration ?

Copy link
Contributor Author

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @wojtek-coreum and @ysv)


integration-tests/coreum/contract_client_test.go line 2244 at r1 (raw file):

Previously, ysv (Yaroslav Savchuk) wrote…

xrpl Token Not Inactive so is it active or not ?
I guess it is double negation done by mistake

either xrplTokenInactive or xrplTokenNotActive

It is not Inactive. The only state when you can recover it is Inactive so when we try to recover with the state which is not Inactive we get that error.


integration-tests/coreum/contract_client_test.go line 2338 at r1 (raw file):

Previously, ysv (Yaroslav Savchuk) wrote…

nit: this file is getting too big
Shall we split it into multiple by business logic or flows e.g: token registration, token send, contract administration ?

We can think a bit later how to split it, the issue is that it is not so simple :-)

Copy link
Collaborator

@ysv ysv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @wojtek-coreum)

@dzmitryhil dzmitryhil merged commit 6affe9b into master Nov 30, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants