Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the newer version of builder which extracts non-essential tools #214

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

masihyeganeh
Copy link
Contributor

@masihyeganeh masihyeganeh commented Jan 24, 2025

Description

It should not be merged before upgrading chain to v5

Reviewers checklist:

  • Try to write more meaningful comments with clear actions to be taken.
  • Nit-picking should be unblocking. Focus on core issues.

Authors checklist

  • Provide a concise and meaningful description
  • Review the code yourself first, before making the PR.
  • Annotate your PR in places that require explanation.
  • Think and try to split the PR to smaller PR if it is big.

This change is Reviewable

@masihyeganeh masihyeganeh requested a review from a team as a code owner January 24, 2025 07:36
@masihyeganeh masihyeganeh requested review from dzmitryhil, miladz68 and ysv and removed request for a team January 24, 2025 07:36
@masihyeganeh masihyeganeh marked this pull request as draft January 24, 2025 09:00
@masihyeganeh masihyeganeh self-assigned this Jan 24, 2025
Copy link
Collaborator

@ysv ysv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 12 of 12 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dzmitryhil and @miladz68)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants