-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add stress tests with failures and refunds #192
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 4 unresolved discussions (waiting on @miladz68, @wojtek-coreum, and @ysv)
integration-tests/stress/sending_stress_test.go
line 173 at r1 (raw file):
func TestStressSendWithFailureAndClaimRefund(t *testing.T) { _, chains := integrationtests.NewTestingContext(t) testAccounts := 10
Those values should become global, to move them to the CLI later.
integration-tests/stress/sending_stress_test.go
line 204 at r1 (raw file):
// generate and fund accounts type xrplAccount struct { Acccount rippledata.Account
Acccount -> Account
integration-tests/stress/sending_stress_test.go
line 270 at r1 (raw file):
return err } waitCtx, waitCancel := context.WithTimeout(ctx, 10*time.Second)
I propose to use the timeouts set-up as test arg or event all tests arg, since it might not fit the real testnet as the result it will be difficult to update it in multiple places
integration-tests/stress/sending_stress_test.go
line 271 at r1 (raw file):
} waitCtx, waitCancel := context.WithTimeout(ctx, 10*time.Second) defer waitCancel()
Wrong usage of the defer waitCancel()
and in the else
as well. You are inside loop here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 4 unresolved discussions (waiting on @dzmitryhil, @wojtek-coreum, and @ysv)
integration-tests/stress/sending_stress_test.go
line 173 at r1 (raw file):
Previously, dzmitryhil (Dzmitry Hil) wrote…
Those values should become global, to move them to the CLI later.
Done.
integration-tests/stress/sending_stress_test.go
line 204 at r1 (raw file):
Previously, dzmitryhil (Dzmitry Hil) wrote…
Acccount -> Account
Done.
integration-tests/stress/sending_stress_test.go
line 270 at r1 (raw file):
Previously, dzmitryhil (Dzmitry Hil) wrote…
I propose to use the timeouts set-up as test arg or event all tests arg, since it might not fit the real testnet as the result it will be difficult to update it in multiple places
I moved the timeout inside the functions and increased the amount to 20 seconds. I don't think anything more than that is needed. I think we should introduce more params only if necessary.
integration-tests/stress/sending_stress_test.go
line 271 at r1 (raw file):
Previously, dzmitryhil (Dzmitry Hil) wrote…
Wrong usage of the
defer waitCancel()
and in theelse
as well. You are inside loop here.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @wojtek-coreum and @ysv)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @wojtek-coreum and @ysv)
Description
Add stress tests with failures and refunds
Reviewers checklist:
Authors checklist
This change is