Skip to content

Commit

Permalink
Fix misspellings and code duplication (#181)
Browse files Browse the repository at this point in the history
  • Loading branch information
dzmitryhil authored Mar 5, 2024
1 parent 7600962 commit d11af9e
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 6 deletions.
7 changes: 3 additions & 4 deletions relayer/client/bridge.go
Original file line number Diff line number Diff line change
Expand Up @@ -453,7 +453,6 @@ func (b *BridgeClient) RegisterXRPLToken(
zap.String("currency", stringCurrency),
zap.Int32("sendingPrecision", sendingPrecision),
zap.String("maxHoldingAmount", maxHoldingAmount.String()),
zap.String("maxHoldingAmount", maxHoldingAmount.String()),
zap.String("bridgingFee", bridgingFee.String()),
)
txRes, err := b.contractClient.RegisterXRPLToken(
Expand Down Expand Up @@ -1063,7 +1062,7 @@ func (b *BridgeClient) validateXRPLBridgeAccountBalance(
ctx context.Context,
xrplBridgeAccount rippledata.Account,
) error {
requiredXRPLBalance := ComputeXRPLBrideAccountBalance()
requiredXRPLBalance := ComputeXRPLBridgeAccountBalance()
b.log.Info(
ctx,
"Compute required XRPL bridge account balance to init the account",
Expand Down Expand Up @@ -1134,8 +1133,8 @@ func (b *BridgeClient) setUpXRPLBridgeAccount(
return b.autoFillSignSubmitAndAwaitXRPLTx(ctx, &disableMasterKeyTx, bridgeAccountKeyName)
}

// ComputeXRPLBrideAccountBalance computes the min balance required by the XRPL bridge account.
func ComputeXRPLBrideAccountBalance() float64 {
// ComputeXRPLBridgeAccountBalance computes the min balance required by the XRPL bridge account.
func ComputeXRPLBridgeAccountBalance() float64 {
return minBalanceToCoverFeeAndTrustLines +
xrpl.ReserveToActivateAccount +
// one additional item reserve is needed for a signer list object for multisig.
Expand Down
2 changes: 1 addition & 1 deletion relayer/cmd/cli/cli.go
Original file line number Diff line number Diff line change
Expand Up @@ -539,7 +539,7 @@ $ bootstrap-bridge bootstrapping.yaml --%s bridge-account
return errors.Wrapf(err, "failed to get %s", FlagRelayersCount)
}
if relayersCount > 0 {
minXrplBridgeBalance := bridgeclient.ComputeXRPLBrideAccountBalance()
minXrplBridgeBalance := bridgeclient.ComputeXRPLBridgeAccountBalance()
components.Log.Info(ctx, "Computed minimum XRPL bridge balance", zap.Float64("balance", minXrplBridgeBalance))
}

Expand Down
2 changes: 1 addition & 1 deletion relayer/runner/runner.go
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ func NewRunner(ctx context.Context, components Components, cfg Config) (*Runner,

contractConfig, err := components.CoreumContractClient.GetContractConfig(ctx)
if err != nil {
return nil, errors.Wrapf(err, "failed to get contract config for the runner intialization")
return nil, errors.Wrapf(err, "failed to get contract config for the runner initialization")
}

bridgeXRPLAddress, err := rippledata.NewAccountFromAddress(contractConfig.BridgeXRPLAddress)
Expand Down

0 comments on commit d11af9e

Please sign in to comment.