Reverse XRPL scanning order (#186)

CoreumFoundation · Mar 6, 2024 · 9ba07a0 · 9ba07a0
1 parent 39b6f2f
commit 9ba07a0
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 6 deletions.
diff --git a/integration-tests/xrpl/scanner_test.go b/integration-tests/xrpl/scanner_test.go
@@ -197,10 +197,10 @@ func validateTxsHashesInChannel(
 		case <-scanCtx.Done():
 			return scanCtx.Err()
 		case tx := <-txsCh:
-			// validate that we have all sent hashed and no duplicated
+			// validate that we have all sent hashes
 			hash := strings.ToUpper(tx.GetHash().String())
 			if _, found := expectedHashes[hash]; !found {
-				return errors.Errorf("not found expected tx hash:%s", hash)
+				continue
 			}
 
 			delete(expectedHashes, hash)

diff --git a/relayer/xrpl/rpc.go b/relayer/xrpl/rpc.go
@@ -339,7 +339,7 @@ func (c *RPCClient) AccountTx(
 		MinLedger: minLedger,
 		MaxLedger: maxLedger,
 		Binary:    false,
-		Forward:   false,
+		Forward:   true,
 		Limit:     c.cfg.PageLimit,
 		Marker:    marker,
 	}

diff --git a/relayer/xrpl/scanner.go b/relayer/xrpl/scanner.go
@@ -199,6 +199,7 @@ func (s *AccountScanner) scanTransactions(
 					lastLedger = prevProcessedLedger
 					prevProcessedLedger = int64(tx.LedgerSequence)
 				}
+				indexRegistryFunc(float64(prevProcessedLedger))
 				if tx == nil {
 					continue
 				}
@@ -209,9 +210,6 @@ func (s *AccountScanner) scanTransactions(
 				}
 			}
 		}
-		if prevProcessedLedger != 0 {
-			indexRegistryFunc(float64(prevProcessedLedger))
-		}
 		if len(accountTxResult.Marker) == 0 {
 			lastLedger = prevProcessedLedger
 			break