Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate packet-forward-middleware #822

Merged
merged 9 commits into from
May 6, 2024
Merged

Conversation

ysv
Copy link
Contributor

@ysv ysv commented May 2, 2024

Description

Reviewers checklist:

  • Try to write more meaningful comments with clear actions to be taken.
  • Nit-picking should be unblocking. Focus on core issues.

Authors checklist

  • Provide a concise and meaningful description
  • Review the code yourself first, before making the PR.
  • Annotate your PR in places that require explanation.
  • Think and try to split the PR to smaller PR if it is big.

This change is Reviewable

@ysv ysv requested a review from a team as a code owner May 2, 2024 17:17
@ysv ysv requested review from masihyeganeh, dzmitryhil, miladz68 and wojtek-coreum and removed request for a team May 2, 2024 17:17
@ysv ysv force-pushed the yaroslav/ibc-pfm-integration-v4 branch from 1ca20b2 to 602a217 Compare May 2, 2024 17:22
Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.08%. Comparing base (e6b3692) to head (33dbe97).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #822   +/-   ##
=======================================
  Coverage   36.08%   36.08%           
=======================================
  Files         181      181           
  Lines       51805    51806    +1     
=======================================
+ Hits        18695    18696    +1     
  Misses      29587    29587           
  Partials     3523     3523           
Flag Coverage Δ
coreum 31.82% <ø> (+<0.01%) ⬆️
coreum-integration-tests-modules 22.57% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dzmitryhil
dzmitryhil previously approved these changes May 3, 2024
Copy link
Contributor

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 9 files reviewed, all discussions resolved (waiting on @masihyeganeh, @miladz68, and @wojtek-coreum)

@ysv ysv force-pushed the yaroslav/ibc-pfm-integration-v4 branch from ea479b1 to 880279c Compare May 3, 2024 13:47
Copy link
Contributor

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 9 files at r1, 1 of 3 files at r2, 6 of 6 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @masihyeganeh and @wojtek-coreum)

Copy link
Contributor

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 9 files at r1, 1 of 3 files at r2, 6 of 6 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @masihyeganeh and @wojtek-coreum)

@ysv ysv merged commit 85078ec into master May 6, 2024
10 checks passed
@ysv ysv deleted the yaroslav/ibc-pfm-integration-v4 branch May 6, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants