Emit deterministic gas event

[wojtek-coreum]

Description

We ant to track real gas consumption by deterministic messages. We decided to emit an event describing deterministic behaviour.

Reviewers checklist:

• Try to write more meaningful comments with clear actions to be taken.
• Nit-picking should be unblocking. Focus on core issues.

Authors checklist

• Provide a concise and meaningful description
• Review the code yourself first, before making the PR.
• Annotate your PR in places that require explanation.
• Think and try to split the PR to smaller PR if it is big.

---

This change is 

[miladz68]

Reviewed 7 of 8 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dzmitryhil and @ysv)

[ysv]

Reviewed 7 of 8 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @dzmitryhil and @wojtek-coreum)

---

x/deterministicgas/types/gas.go line 152 at r2 (raw file):

	}

	err := oldCtx.EventManager().EmitTypedEvent(&EventGas{

I'm not sure that this is the best place to emit this event.
The idea & name of the func is to report Metric but this code is not related to metric

---

x/deterministicgas/types/gas.go line 154 at r2 (raw file):

	err := oldCtx.EventManager().EmitTypedEvent(&EventGas{
		MsgURL:           msgURL,
		RealGas:          realGas,

are we sure we want to expose this info ?
lets discuss with the team

---

x/deterministicgas/types/gas.go line 158 at r2 (raw file):

	})

	if err != nil {

nit: this check is not needed

func WithStack(err error) error {  
if err == nil {  
return nil  
}  
return &withStack{  
err,  
callers(),  
}  
}

but if u find it more obvious I'm ok

[wojtek-coreum]

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @dzmitryhil and @ysv)

---

x/deterministicgas/types/gas.go line 152 at r2 (raw file):

Previously, ysv (Yaroslav Savchuk) wrote…

I'm not sure that this is the best place to emit this event.
The idea & name of the func is to report Metric but this code is not related to metric

let's rename the function then

---

x/deterministicgas/types/gas.go line 154 at r2 (raw file):

Previously, ysv (Yaroslav Savchuk) wrote…

are we sure we want to expose this info ?
lets discuss with the team

why not?

---

x/deterministicgas/types/gas.go line 158 at r2 (raw file):

Previously, ysv (Yaroslav Savchuk) wrote…

nit: this check is not needed

func WithStack(err error) error {  
if err == nil {  
return nil  
}  
return &withStack{  
err,  
callers(),  
}  
}

but if u find it more obvious I'm ok

I would do it as you propose, but last time someone (Dima?) commented that having this for nil error is counterintuitive

[wojtek-coreum]

Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @dzmitryhil and @ysv)

---

x/deterministicgas/types/gas.go line 152 at r2 (raw file):

	}

	err := oldCtx.EventManager().EmitTypedEvent(&EventGas{

include index of the message

[wojtek-coreum]

Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @dzmitryhil and @ysv)

---

x/deterministicgas/types/gas.go line 158 at r2 (raw file):

Previously, wojtek-coreum (Wojtek) wrote…

I would do it as you propose, but last time someone (Dima?) commented that having this for nil error is counterintuitive

let's remove it

[wojtek-coreum]

Reviewable status: 7 of 8 files reviewed, 2 unresolved discussions (waiting on @dzmitryhil, @miladz68, and @ysv)

---

x/deterministicgas/types/gas.go line 152 at r2 (raw file):

Previously, wojtek-coreum (Wojtek) wrote…

include index of the message

I have no access to the index there

[dzmitryhil]

Reviewable status: 7 of 8 files reviewed, 2 unresolved discussions (waiting on @miladz68 and @ysv)

[ysv]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @miladz68)