Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change voting period to 4h on devnet #453

Merged
merged 2 commits into from
Mar 23, 2023
Merged

Conversation

wojtek-coreum
Copy link
Collaborator

@wojtek-coreum wojtek-coreum commented Mar 21, 2023

This change is Reviewable

Copy link
Contributor

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @miladz68, @silverspase, @wojtek-coreum, and @ysv)


pkg/config/network.go line 117 at r1 (raw file):

	devGovConfig := govConfig
	devGovConfig.ProposalConfig.VotingPeriod = "4h"

I thought we want it for the testnet only. @ysv ?

Copy link
Collaborator Author

@wojtek-coreum wojtek-coreum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @miladz68, @silverspase, and @ysv)


pkg/config/network.go line 117 at r1 (raw file):

Previously, dzmitryhil (Dzmitry Hil) wrote…

I thought we want it for the testnet only. @ysv ?

Change Voting period on testnet & devnet to 4h (@wojtek, @Yaroslav Savchuk)

Copy link
Contributor

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @miladz68, @silverspase, and @ysv)


pkg/config/network.go line 117 at r1 (raw file):

Previously, wojtek-coreum (Wojtek) wrote…
Change Voting period on testnet & devnet to 4h (@wojtek, @Yaroslav Savchuk)

Clreat

Copy link
Contributor

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @silverspase and @ysv)

Copy link
Contributor

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @silverspase and @ysv)

Copy link
Collaborator Author

@wojtek-coreum wojtek-coreum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @silverspase and @ysv)


pkg/config/network.go line 117 at r1 (raw file):

Previously, dzmitryhil (Dzmitry Hil) wrote…

Clreat

So please unblock :)

@ysv ysv requested a review from dzmitryhil March 23, 2023 11:38
Copy link
Contributor

@ysv ysv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dzmitryhil and @silverspase)

Copy link
Contributor

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @silverspase)

@wojtek-coreum wojtek-coreum merged commit 612e6e3 into master Mar 23, 2023
@wojtek-coreum wojtek-coreum deleted the wojtek/dev-voting-period branch March 23, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants