Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate nft genesis #447

Merged
merged 3 commits into from
Mar 16, 2023
Merged

validate nft genesis #447

merged 3 commits into from
Mar 16, 2023

Conversation

miladz68
Copy link
Contributor

@miladz68 miladz68 commented Mar 16, 2023

This change is Reviewable

dzmitryhil
dzmitryhil previously approved these changes Mar 16, 2023
Copy link
Contributor

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @silverspase, @wojtek-coreum, and @ysv)

Copy link
Contributor

@ysv ysv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @miladz68, @silverspase, and @wojtek-coreum)


x/asset/nft/types/genesis.go line 16 at r1 (raw file):

// Validate performs basic genesis state validation returning an error upon any failure.
func (gs GenesisState) Validate() error {
	for _, s := range gs.ClassDefinitions {

cd varible name is clear but what does s mean ?


x/asset/nft/types/genesis.go line 28 at r1 (raw file):

	}

	for _, cd := range gs.FrozenNFTs {

you iterate over FrozenNFTs twice
Is there anything specific ?

Copy link
Contributor Author

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @silverspase, @wojtek-coreum, and @ysv)


x/asset/nft/types/genesis.go line 16 at r1 (raw file):

Previously, ysv (Yaroslav Savchuk) wrote…

cd varible name is clear but what does s mean ?

Done.


x/asset/nft/types/genesis.go line 28 at r1 (raw file):

Previously, ysv (Yaroslav Savchuk) wrote…

you iterate over FrozenNFTs twice
Is there anything specific ?

Done, my mistake.

Copy link
Contributor

@ysv ysv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @silverspase and @wojtek-coreum)

Copy link
Contributor

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @silverspase and @wojtek-coreum)

@miladz68 miladz68 merged commit 727653d into master Mar 16, 2023
@miladz68 miladz68 deleted the milad/validate-nft-genesis branch March 16, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants