-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
validate nft genesis #447
validate nft genesis #447
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @silverspase, @wojtek-coreum, and @ysv)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @miladz68, @silverspase, and @wojtek-coreum)
x/asset/nft/types/genesis.go
line 16 at r1 (raw file):
// Validate performs basic genesis state validation returning an error upon any failure. func (gs GenesisState) Validate() error { for _, s := range gs.ClassDefinitions {
cd varible name is clear but what does s mean ?
x/asset/nft/types/genesis.go
line 28 at r1 (raw file):
} for _, cd := range gs.FrozenNFTs {
you iterate over FrozenNFTs twice
Is there anything specific ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @silverspase, @wojtek-coreum, and @ysv)
x/asset/nft/types/genesis.go
line 16 at r1 (raw file):
Previously, ysv (Yaroslav Savchuk) wrote…
cd varible name is clear but what does s mean ?
Done.
x/asset/nft/types/genesis.go
line 28 at r1 (raw file):
Previously, ysv (Yaroslav Savchuk) wrote…
you iterate over FrozenNFTs twice
Is there anything specific ?
Done, my mistake.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @silverspase and @wojtek-coreum)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @silverspase and @wojtek-coreum)
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)