Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more test cases for fungible token #381

Merged
merged 3 commits into from
Feb 10, 2023

Conversation

miladz68
Copy link
Contributor

@miladz68 miladz68 commented Feb 8, 2023

This change is Reviewable

@miladz68 miladz68 force-pushed the milad/ft-complex-integration-1 branch from cf9b89d to abeb229 Compare February 8, 2023 09:55
Copy link
Collaborator

@wojtek-coreum wojtek-coreum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dzmitryhil, @miladz68, @silverspase, and @ysv)


integration-tests/modules/assetft_test.go line 1800 at r1 (raw file):

// TestBareToken checks non of the features will work if the flags are not set.
func TestBareToken(t *testing.T) {

what about burning?

Copy link
Contributor

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @silverspase, @wojtek-coreum, and @ysv)


integration-tests/modules/assetft_test.go line 1800 at r1 (raw file):

Previously, wojtek-coreum (Wojtek) wrote…

what about burning?

Agree, let's add text that burning will work for the issuer. And add it to the test case.

Copy link
Contributor

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @silverspase, @wojtek-coreum, and @ysv)

Copy link
Contributor Author

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @dzmitryhil, @silverspase, @wojtek-coreum, and @ysv)


integration-tests/modules/assetft_test.go line 1800 at r1 (raw file):

Previously, dzmitryhil (Dzmitry Hil) wrote…

Agree, let's add text that burning will work for the issuer. And add it to the test case.

Added.

Copy link
Collaborator

@wojtek-coreum wojtek-coreum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @silverspase and @ysv)

Copy link
Contributor

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @silverspase and @ysv)

@miladz68 miladz68 merged commit 6480cbf into master Feb 10, 2023
@miladz68 miladz68 deleted the milad/ft-complex-integration-1 branch February 10, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants