Added validate precision and subunit

[miladz68]

This change is 

[wojtek-coreum]

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dzmitryhil, @miladz68, @silverspase, and @ysv)

---

x/asset/ft/types/token.go line 98 at r1 (raw file):

// ValidatePrecision checks the provided precision is valid.
func ValidatePrecision(precision uint32) error {
	if precision == 0 || precision > maxPrecision {

precision 0 is a pretty valid usecase

[dzmitryhil]

Let's not reference to certik in the PRs and comment. Update the final comment message with the content you provide please.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @silverspase, @wojtek-coreum, and @ysv)

---

x/asset/ft/types/token.go line 98 at r1 (raw file):

Previously, wojtek-coreum (Wojtek) wrote…

precision 0 is a pretty valid usecase

Do we handle a case with zero precision? Seems like we don't need to add additional denom to the metadata in that case.

[miladz68]

Done

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @silverspase, @wojtek-coreum, and @ysv)

---

x/asset/ft/types/token.go line 98 at r1 (raw file):

Previously, dzmitryhil (Dzmitry Hil) wrote…

Do we handle a case with zero precision? Seems like we don't need to add additional denom to the metadata in that case.

precision 0 is not supported by cosmos sdk, if we want to regsiter with bank metatdata, a precision higher than zero must be provided.

[wojtek-coreum]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @silverspase and @ysv)

[wojtek-coreum]

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @silverspase and @ysv)

[dzmitryhil]

Reviewed 1 of 2 files at r3.
Reviewable status: 4 of 5 files reviewed, all discussions resolved (waiting on @silverspase, @wojtek-coreum, and @ysv)

[dzmitryhil]

Reviewed 1 of 3 files at r1, 2 of 3 files at r2, 1 of 2 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @silverspase and @ysv)

[dzmitryhil]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @silverspase and @ysv)

[dzmitryhil]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @silverspase and @ysv)

[wojtek-coreum]

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @silverspase and @ysv)