Add unknown message metric.

[dzmitryhil]

Example:

# HELP unknown_message unknown_message
# TYPE unknown_message counter
unknown_message{msg_name="/coreum.asset.ft.v1.MsgIssue"} 1

---

This change is 

[miladz68]

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @silverspase, @wojtek-coreum, and @ysv)

[ysv]

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @dzmitryhil, @silverspase, and @wojtek-coreum)

---

x/deterministicgas/config.go line 48 at r1 (raw file):

	cfg.gasByMsg = map[string]gasByMsgFunc{
		// asset/ft
		//MsgType(&assetfttypes.MsgIssue{}):               constantGasFunc(70000),

ok, but pls rollback it before merging to master)

---

x/deterministicgas/config.go line 152 at r1 (raw file):

	// In the future other approach could be to return third boolean parameter
	// identifying if message is known and report unknown messages to monitoring.
	reportUnknownMessageMetric(MsgType(msg))

are u going to add this to grafana in a next crust PR also ?

---

x/deterministicgas/config.go line 240 at r1 (raw file):

func reportUnknownMessageMetric(msgName string) {
	metrics.IncrCounterWithLabels([]string{"unknown_message"}, 1, []metrics.Label{

shouldn't it be deterministic_gas_unknown_message ?
Because in general this message is know but unknown only for determ gas module

[dzmitryhil]

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @silverspase, @wojtek-coreum, and @ysv)

---

x/deterministicgas/config.go line 48 at r1 (raw file):

Previously, ysv (Yaroslav Savchuk) wrote…

ok, but pls rollback it before merging to master)

Updated.

---

x/deterministicgas/config.go line 152 at r1 (raw file):

Previously, ysv (Yaroslav Savchuk) wrote…

are u going to add this to grafana in a next crust PR also ?

No need to add it to the grafana, since such dashboard will be always empty. What I can do is to add it as allert. does it make sense?

---

x/deterministicgas/config.go line 240 at r1 (raw file):

Previously, ysv (Yaroslav Savchuk) wrote…

shouldn't it be deterministic_gas_unknown_message ?
Because in general this message is know but unknown only for determ gas module

Agree, updated.

[wojtek-coreum]

Reviewable status: 0 of 1 files reviewed, 4 unresolved discussions (waiting on @dzmitryhil, @miladz68, @silverspase, and @ysv)

a discussion (no related file):
Is this PR really needed? We have unit test which verifies that all the messages are handled. So this condition is just impossible.

---

[miladz68]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @dzmitryhil, @silverspase, and @ysv)

[dzmitryhil]

Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @silverspase, @wojtek-coreum, and @ysv)

a discussion (no related file):

Previously, wojtek-coreum (Wojtek) wrote…

Is this PR really needed? We have unit test which verifies that all the messages are handled. So this condition is just impossible.

I also have such dought. Let's discuss today.

---

[ysv]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @silverspase and @wojtek-coreum)

---

x/deterministicgas/config.go line 152 at r1 (raw file):

Previously, dzmitryhil (Dzmitry Hil) wrote…

No need to add it to the grafana, since such dashboard will be always empty. What I can do is to add it as allert. does it make sense?

alert yes

[dzmitryhil]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @silverspase, @wojtek-coreum, and @ysv)

a discussion (no related file):

Previously, dzmitryhil (Dzmitry Hil) wrote…

I also have such dought. Let's discuss today.

@ysv what about that question?

---

[ysv]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @silverspase and @wojtek-coreum)

a discussion (no related file):

Previously, dzmitryhil (Dzmitry Hil) wrote…

@ysv what about that question?

lets discuss after the daily
Adde to my notes

---

[wojtek-coreum]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @silverspase)

[wojtek-coreum]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @silverspase)