Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate the testnet coreum config. #340

Merged
merged 3 commits into from
Jan 13, 2023
Merged

Conversation

dzmitryhil
Copy link
Contributor

@dzmitryhil dzmitryhil commented Jan 11, 2023

This change is Reviewable

Copy link
Contributor

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 11 of 11 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dzmitryhil, @silverspase, @wojtek-coreum, and @ysv)


pkg/config/network_test.go line 125 at r1 (raw file):

}

func TestAddFundsToGenesis(t *testing.T) {

we introduced a FundAccounts function in this module and this tests, tests that. it is a good tests to have and we should not remove it.

Copy link
Contributor

@ysv ysv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 11 of 11 files at r1, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @dzmitryhil, @silverspase, and @wojtek-coreum)


pkg/config/network.go line 39 at r1 (raw file):

	//go:embed genesis/gentx/coreum-devnet-1
	devGenTxsFS embed.FS

minor:
I see you renamed devnet to dev in a few places. I still prefer devnet


pkg/config/network.go line 114 at r1 (raw file):

		constant.ChainIDTest: {
			ChainID:              constant.ChainIDTest,
			Enabled:              true,

can we make testnet default env from now


pkg/config/network.go line 115 at r1 (raw file):

			ChainID:              constant.ChainIDTest,
			Enabled:              true,
			GenesisTime:          time.Date(2023, 1, 1, 12, 0, 0, 0, time.UTC),

official launch date is 18.01.2023 lets put it here


pkg/config/network_test.go line 258 at r1 (raw file):

}

func setField(object interface{}, fieldName string, value interface{}) {

minor: unsafeSetField ?

Copy link
Contributor Author

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @silverspase, @wojtek-coreum, and @ysv)


pkg/config/network.go line 39 at r1 (raw file):

Previously, ysv (Yaroslav Savchuk) wrote…

minor:
I see you renamed devnet to dev in a few places. I still prefer devnet

Actually I did it becase they called dev in 90% of places.


pkg/config/network.go line 114 at r1 (raw file):

Previously, ysv (Yaroslav Savchuk) wrote…

can we make testnet default env from now

Sure we can. Updated.


pkg/config/network.go line 115 at r1 (raw file):

Previously, ysv (Yaroslav Savchuk) wrote…

official launch date is 18.01.2023 lets put it here

Done.

Code quote:

 time.Date(2023, 1, 1, 12, 0, 0, 0, time

pkg/config/network_test.go line 258 at r1 (raw file):

Previously, ysv (Yaroslav Savchuk) wrote…

minor: unsafeSetField ?

Updated.

ysv
ysv previously approved these changes Jan 12, 2023
Copy link
Contributor

@ysv ysv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @silverspase and @wojtek-coreum)

miladz68
miladz68 previously approved these changes Jan 12, 2023
Copy link
Contributor

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 11 of 11 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @silverspase and @wojtek-coreum)

@dzmitryhil dzmitryhil dismissed stale reviews from miladz68 and ysv via 837c14f January 13, 2023 10:31
@dzmitryhil dzmitryhil requested review from miladz68 and ysv January 13, 2023 10:56
Copy link
Contributor

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @silverspase, @wojtek-coreum, and @ysv)

Copy link
Contributor

@ysv ysv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @silverspase and @wojtek-coreum)

@dzmitryhil dzmitryhil merged commit 60774f9 into master Jan 13, 2023
@dzmitryhil dzmitryhil deleted the dzmitryhil/testnet-config branch January 13, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants