Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed default network configs in init command #1058

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

miladz68
Copy link
Contributor

@miladz68 miladz68 commented Jan 1, 2025

Description

Reviewers checklist:

  • Try to write more meaningful comments with clear actions to be taken.
  • Nit-picking should be unblocking. Focus on core issues.

Authors checklist

  • Provide a concise and meaningful description
  • Review the code yourself first, before making the PR.
  • Annotate your PR in places that require explanation.
  • Think and try to split the PR to smaller PR if it is big.

This change is Reviewable

@miladz68 miladz68 requested a review from a team as a code owner January 1, 2025 07:31
@miladz68 miladz68 requested review from masihyeganeh, dzmitryhil and ysv and removed request for a team January 1, 2025 07:31
Copy link

codecov bot commented Jan 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.45%. Comparing base (8910002) to head (336f9da).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1058      +/-   ##
==========================================
+ Coverage   60.48%   62.45%   +1.96%     
==========================================
  Files         160      160              
  Lines       18587    18590       +3     
==========================================
+ Hits        11243    11610     +367     
+ Misses       6240     5861     -379     
- Partials     1104     1119      +15     
Flag Coverage Δ
coreum 57.08% <0.00%> (-0.01%) ⬇️
coreum-integration-tests-modules 52.56% <100.00%> (+6.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@masihyeganeh masihyeganeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dzmitryhil and @ysv)

@miladz68 miladz68 merged commit d1b60ff into master Jan 2, 2025
11 checks passed
@miladz68 miladz68 deleted the milad/change-some-config branch January 2, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants