Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add AMD/ARM 64 images for the docker action. #34

Merged
merged 2 commits into from
Apr 6, 2023

Conversation

dzmitryhil
Copy link

@dzmitryhil dzmitryhil commented Apr 4, 2023

Description

Add AMD/ARM 64 images for the docker action.


This change is Reviewable

@dzmitryhil dzmitryhil changed the title Add AMD/ARM 64 images for the docker action. feat: Add AMD/ARM 64 images for the docker action. Apr 4, 2023
@dzmitryhil dzmitryhil changed the title feat: Add AMD/ARM 64 images for the docker action. feat: add AMD/ARM 64 images for the docker action. Apr 4, 2023
Copy link

@ysv ysv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @alinetskyi, @dzmitryhil, @miladz68, and @wojtek-coreum)


.github/workflows/build.yml line 46 at r1 (raw file):

          push: true
          build-args: |
            "NEXT_PUBLIC_GRAPHQL_URL=http://localhost:8080/v1/graphql"

but do we really still need all these variables ?

Copy link

@ysv ysv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @alinetskyi, @dzmitryhil, @miladz68, and @wojtek-coreum)


.github/workflows/build.yml line 46 at r1 (raw file):

Previously, ysv (Yaroslav Savchuk) wrote…

but do we really still need all these variables ?

I see they are for compatibility with znet inside crust
But I suggest to not use this trick but instead set envs inside crust directly
using

infra.Deployment {
	EnvVarsFunc func() []EnvVar
}

Copy link
Author

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @alinetskyi, @miladz68, @wojtek-coreum, and @ysv)


.github/workflows/build.yml line 46 at r1 (raw file):

Previously, ysv (Yaroslav Savchuk) wrote…

I see they are for compatibility with znet inside crust
But I suggest to not use this trick but instead set envs inside crust directly
using

infra.Deployment {
	EnvVarsFunc func() []EnvVar
}

But that's not trick. The values are default values, connected to the localhost, which should be by default.
I can duplicate them in the crust, if you see it's important. But IMO we don't need to do it.

Copy link

@ysv ysv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @alinetskyi, @dzmitryhil, @miladz68, and @wojtek-coreum)


.github/workflows/build.yml line 46 at r1 (raw file):

Previously, dzmitryhil (Dzmitry Hil) wrote…

But that's not trick. The values are default values, connected to the localhost, which should be by default.
I can duplicate them in the crust, if you see it's important. But IMO we don't need to do it.

In original big dipper repo they don't specify these build-args
https://github.com/forbole/big-dipper-2.0-cosmos/blob/main/.github/workflows/publish.yml#L89

So I suggest we keep it similar. Lets not specify them if they are not needed

Also yes lets put these values in crust pls

Copy link
Author

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @alinetskyi, @miladz68, @wojtek-coreum, and @ysv)


.github/workflows/build.yml line 46 at r1 (raw file):

Previously, ysv (Yaroslav Savchuk) wrote…

In original big dipper repo they don't specify these build-args
https://github.com/forbole/big-dipper-2.0-cosmos/blob/main/.github/workflows/publish.yml#L89

So I suggest we keep it similar. Lets not specify them if they are not needed

Also yes lets put these values in crust pls

Removed all apart from "PROJECT_NAME=web-coreum" which is required for the build.

Code quote:

 "PROJECT_NAME=web-coreum"

@dzmitryhil dzmitryhil requested a review from ysv April 5, 2023 12:57
Copy link

@ysv ysv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @alinetskyi, @miladz68, and @wojtek-coreum)

@dzmitryhil dzmitryhil merged commit 4e0a2e6 into master Apr 6, 2023
akhlopiachyi pushed a commit that referenced this pull request Oct 2, 2023
* Add AMD/ARM 64 images for the docker action.
@akhlopiachyi akhlopiachyi deleted the dzmitryhil/buildx branch October 5, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants