-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add AMD/ARM 64 images for the docker action. #34
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @alinetskyi, @dzmitryhil, @miladz68, and @wojtek-coreum)
.github/workflows/build.yml
line 46 at r1 (raw file):
push: true build-args: | "NEXT_PUBLIC_GRAPHQL_URL=http://localhost:8080/v1/graphql"
but do we really still need all these variables ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @alinetskyi, @dzmitryhil, @miladz68, and @wojtek-coreum)
.github/workflows/build.yml
line 46 at r1 (raw file):
Previously, ysv (Yaroslav Savchuk) wrote…
but do we really still need all these variables ?
I see they are for compatibility with znet inside crust
But I suggest to not use this trick but instead set envs inside crust directly
using
infra.Deployment {
EnvVarsFunc func() []EnvVar
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @alinetskyi, @miladz68, @wojtek-coreum, and @ysv)
.github/workflows/build.yml
line 46 at r1 (raw file):
Previously, ysv (Yaroslav Savchuk) wrote…
I see they are for compatibility with znet inside crust
But I suggest to not use this trick but instead set envs inside crust directly
usinginfra.Deployment { EnvVarsFunc func() []EnvVar }
But that's not trick. The values are default values, connected to the localhost, which should be by default.
I can duplicate them in the crust, if you see it's important. But IMO we don't need to do it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @alinetskyi, @dzmitryhil, @miladz68, and @wojtek-coreum)
.github/workflows/build.yml
line 46 at r1 (raw file):
Previously, dzmitryhil (Dzmitry Hil) wrote…
But that's not trick. The values are default values, connected to the localhost, which should be by default.
I can duplicate them in the crust, if you see it's important. But IMO we don't need to do it.
In original big dipper repo they don't specify these build-args
https://github.com/forbole/big-dipper-2.0-cosmos/blob/main/.github/workflows/publish.yml#L89
So I suggest we keep it similar. Lets not specify them if they are not needed
Also yes lets put these values in crust pls
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @alinetskyi, @miladz68, @wojtek-coreum, and @ysv)
.github/workflows/build.yml
line 46 at r1 (raw file):
Previously, ysv (Yaroslav Savchuk) wrote…
In original big dipper repo they don't specify these build-args
https://github.com/forbole/big-dipper-2.0-cosmos/blob/main/.github/workflows/publish.yml#L89So I suggest we keep it similar. Lets not specify them if they are not needed
Also yes lets put these values in crust pls
Removed all apart from "PROJECT_NAME=web-coreum"
which is required for the build.
Code quote:
"PROJECT_NAME=web-coreum"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @alinetskyi, @miladz68, and @wojtek-coreum)
* Add AMD/ARM 64 images for the docker action.
Description
Add AMD/ARM 64 images for the docker action.
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)