Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize volume normalization #104

Merged
merged 3 commits into from
Aug 31, 2019
Merged

optimize volume normalization #104

merged 3 commits into from
Aug 31, 2019

Conversation

lidalei
Copy link
Contributor

@lidalei lidalei commented Aug 30, 2019

fix a logical bug, missing parentheses.
Optimization:
20 * log10(sqrt(np.mean((wav * max_possible_amplitude)^2)) / max_possible_amplitude)
= 20 * log10(sqrt(max_possible_amplitude^2 * np.mean(wav^2)) / max_possible_amplitude)
= 20 * log10(max_possible_amplitude * sqrt(np.mean(wav^2)) / max_possible_amplitude)
= 20 * log10(sqrt(np.mean(wav^2)))
= 10 * log10(np.mean(wav^2))

fix a logical bug, missing parentheses
encoder/audio.py Outdated Show resolved Hide resolved
@CorentinJ
Copy link
Owner

Thank you.

@CorentinJ CorentinJ merged commit 8e6499b into CorentinJ:master Aug 31, 2019
@lidalei lidalei deleted the patch-1 branch August 31, 2019 22:18
kiku-jw added a commit to kiku-jw/Real-Time-Voice-Cloning that referenced this pull request Sep 3, 2019
Optimized volume normalization (CorentinJ#104)
LmYjQ pushed a commit to LmYjQ/Real-Time-Voice-Cloning that referenced this pull request Nov 12, 2019
LmYjQ pushed a commit to LmYjQ/Real-Time-Voice-Cloning that referenced this pull request Nov 12, 2019
LmYjQ pushed a commit to LmYjQ/Real-Time-Voice-Cloning that referenced this pull request Nov 12, 2019
LmYjQ pushed a commit to LmYjQ/Real-Time-Voice-Cloning that referenced this pull request Nov 12, 2019
zrb250 pushed a commit to zrb250/sv2tts that referenced this pull request Dec 13, 2019
zrb250 pushed a commit to zrb250/sv2tts that referenced this pull request Dec 13, 2019
zrb250 pushed a commit to zrb250/sv2tts that referenced this pull request Dec 13, 2019
zrb250 pushed a commit to zrb250/sv2tts that referenced this pull request Dec 13, 2019
zrb250 pushed a commit to zrb250/sv2tts that referenced this pull request Dec 17, 2019
zrb250 pushed a commit to zrb250/sv2tts that referenced this pull request Dec 17, 2019
zrb250 pushed a commit to zrb250/sv2tts that referenced this pull request Dec 17, 2019
zrb250 pushed a commit to zrb250/sv2tts that referenced this pull request Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants