Skip to content

Commit

Permalink
feat: upgrade react-slick (ant-design#48093)
Browse files Browse the repository at this point in the history 
* feat: upgrade react-slick

* test: update snapshots

* test: update snapshots

---------

Co-authored-by: lijianan <574980606@qq.com>
  • Loading branch information
@afc163 @li-jia-nan @CooperHash
2 people authored and CooperHash committed Apr 10, 2024
1 parent 657c19f commit 69df931
Show file tree
Hide file tree
Showing 4 changed files with 176 additions and 9 deletions.
8 changes: 4 additions & 4 deletions components/carousel/__tests__/__snapshots__/demo-extend.test.ts.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -727,7 +727,7 @@ exports[`renders components/carousel/demo/fade.tsx extend context correctly 1`]
aria-hidden="false"
class="slick-slide slick-active slick-current"
data-index="0"
style="outline: none; width: 0px; position: relative; left: 0px; opacity: 1; transition: opacity 500ms ease, visibility 500ms ease;"
style="outline: none; width: 0px; position: relative; left: 0px; opacity: 1; z-index: 999; transition: opacity 500ms ease, visibility 500ms ease;"
tabindex="-1"
>
<div>
Expand All @@ -747,7 +747,7 @@ exports[`renders components/carousel/demo/fade.tsx extend context correctly 1`]
aria-hidden="true"
class="slick-slide"
data-index="1"
style="outline: none; width: 0px; position: relative; left: 0px; opacity: 0; transition: opacity 500ms ease, visibility 500ms ease;"
style="outline: none; width: 0px; position: relative; left: 0px; opacity: 0; z-index: 998; transition: opacity 500ms ease, visibility 500ms ease;"
tabindex="-1"
>
<div>
Expand All @@ -767,7 +767,7 @@ exports[`renders components/carousel/demo/fade.tsx extend context correctly 1`]
aria-hidden="true"
class="slick-slide"
data-index="2"
style="outline: none; width: 0px; position: relative; left: 0px; opacity: 0; transition: opacity 500ms ease, visibility 500ms ease;"
style="outline: none; width: 0px; position: relative; left: 0px; opacity: 0; z-index: 998; transition: opacity 500ms ease, visibility 500ms ease;"
tabindex="-1"
>
<div>
Expand All @@ -787,7 +787,7 @@ exports[`renders components/carousel/demo/fade.tsx extend context correctly 1`]
aria-hidden="true"
class="slick-slide"
data-index="3"
style="outline: none; width: 0px; position: relative; left: 0px; opacity: 0; transition: opacity 500ms ease, visibility 500ms ease;"
style="outline: none; width: 0px; position: relative; left: 0px; opacity: 0; z-index: 998; transition: opacity 500ms ease, visibility 500ms ease;"
tabindex="-1"
>
<div>
Expand Down
8 changes: 4 additions & 4 deletions components/carousel/__tests__/__snapshots__/demo.test.ts.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -721,7 +721,7 @@ exports[`renders components/carousel/demo/fade.tsx correctly 1`] = `
aria-hidden="false"
class="slick-slide slick-active slick-current"
data-index="0"
style="outline:none;width:11.11111111111111%;position:relative;left:0;opacity:1;transition:opacity 500ms ease, visibility 500ms ease"
style="outline:none;width:11.11111111111111%;position:relative;left:0;opacity:1;z-index:999;transition:opacity 500ms ease, visibility 500ms ease"
tabindex="-1"
>
<div>
Expand All @@ -741,7 +741,7 @@ exports[`renders components/carousel/demo/fade.tsx correctly 1`] = `
aria-hidden="true"
class="slick-slide"
data-index="1"
style="outline:none;width:11.11111111111111%;position:relative;left:-11px;opacity:0;transition:opacity 500ms ease, visibility 500ms ease"
style="outline:none;width:11.11111111111111%;position:relative;left:-11px;opacity:0;z-index:998;transition:opacity 500ms ease, visibility 500ms ease"
tabindex="-1"
>
<div>
Expand All @@ -761,7 +761,7 @@ exports[`renders components/carousel/demo/fade.tsx correctly 1`] = `
aria-hidden="true"
class="slick-slide"
data-index="2"
style="outline:none;width:11.11111111111111%;position:relative;left:-22px;opacity:0;transition:opacity 500ms ease, visibility 500ms ease"
style="outline:none;width:11.11111111111111%;position:relative;left:-22px;opacity:0;z-index:998;transition:opacity 500ms ease, visibility 500ms ease"
tabindex="-1"
>
<div>
Expand All @@ -781,7 +781,7 @@ exports[`renders components/carousel/demo/fade.tsx correctly 1`] = `
aria-hidden="true"
class="slick-slide"
data-index="3"
style="outline:none;width:11.11111111111111%;position:relative;left:-33px;opacity:0;transition:opacity 500ms ease, visibility 500ms ease"
style="outline:none;width:11.11111111111111%;position:relative;left:-33px;opacity:0;z-index:998;transition:opacity 500ms ease, visibility 500ms ease"
tabindex="-1"
>
<div>
Expand Down
167 changes: 167 additions & 0 deletions components/carousel/__tests__/__snapshots__/index.test.tsx.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ exports[`Carousel rtl render component should be rendered correctly in RTL direc
>
<div
class="slick-slider slick-initialized"
dir="ltr"
>
<div
class="slick-list"
Expand All @@ -25,6 +26,7 @@ exports[`Carousel should works for dotPosition bottom 1`] = `
>
<div
class="slick-slider slick-initialized"
dir="ltr"
>
<div
class="slick-list"
Expand All @@ -33,6 +35,20 @@ exports[`Carousel should works for dotPosition bottom 1`] = `
class="slick-track"
style="opacity: 1; transform: translate3d(0px, 0px, 0px);"
>
<div
aria-hidden="true"
class="slick-slide slick-cloned"
data-index="-1"
style="width: 0px;"
tabindex="-1"
>
<div>
<div
style="width: 100%; display: inline-block;"
tabindex="-1"
/>
</div>
</div>
<div
aria-hidden="false"
class="slick-slide slick-active slick-current"
Expand All @@ -47,8 +63,34 @@ exports[`Carousel should works for dotPosition bottom 1`] = `
/>
</div>
</div>
<div
aria-hidden="true"
class="slick-slide slick-cloned"
data-index="1"
style="width: 0px;"
tabindex="-1"
>
<div>
<div
style="width: 100%; display: inline-block;"
tabindex="-1"
/>
</div>
</div>
</div>
</div>
<ul
class="slick-dots slick-dots-bottom"
style="display: block;"
>
<li
class="slick-active"
>
<button>
1
</button>
</li>
</ul>
</div>
</div>
`;
Expand All @@ -59,14 +101,30 @@ exports[`Carousel should works for dotPosition left 1`] = `
>
<div
class="slick-slider slick-vertical slick-initialized"
dir="ltr"
>
<div
class="slick-list"
style="height: 0px;"
>
<div
class="slick-track"
style="opacity: 1; transform: translate3d(0px, 0px, 0px);"
>
<div
aria-hidden="true"
class="slick-slide slick-cloned"
data-index="-1"
style="width: 0px;"
tabindex="-1"
>
<div>
<div
style="width: 100%; display: inline-block;"
tabindex="-1"
/>
</div>
</div>
<div
aria-hidden="false"
class="slick-slide slick-active slick-current"
Expand All @@ -81,8 +139,34 @@ exports[`Carousel should works for dotPosition left 1`] = `
/>
</div>
</div>
<div
aria-hidden="true"
class="slick-slide slick-cloned"
data-index="1"
style="width: 0px;"
tabindex="-1"
>
<div>
<div
style="width: 100%; display: inline-block;"
tabindex="-1"
/>
</div>
</div>
</div>
</div>
<ul
class="slick-dots slick-dots-left"
style="display: block;"
>
<li
class="slick-active"
>
<button>
1
</button>
</li>
</ul>
</div>
</div>
`;
Expand All @@ -93,14 +177,30 @@ exports[`Carousel should works for dotPosition right 1`] = `
>
<div
class="slick-slider slick-vertical slick-initialized"
dir="ltr"
>
<div
class="slick-list"
style="height: 0px;"
>
<div
class="slick-track"
style="opacity: 1; transform: translate3d(0px, 0px, 0px);"
>
<div
aria-hidden="true"
class="slick-slide slick-cloned"
data-index="-1"
style="width: 0px;"
tabindex="-1"
>
<div>
<div
style="width: 100%; display: inline-block;"
tabindex="-1"
/>
</div>
</div>
<div
aria-hidden="false"
class="slick-slide slick-active slick-current"
Expand All @@ -115,8 +215,34 @@ exports[`Carousel should works for dotPosition right 1`] = `
/>
</div>
</div>
<div
aria-hidden="true"
class="slick-slide slick-cloned"
data-index="1"
style="width: 0px;"
tabindex="-1"
>
<div>
<div
style="width: 100%; display: inline-block;"
tabindex="-1"
/>
</div>
</div>
</div>
</div>
<ul
class="slick-dots slick-dots-right"
style="display: block;"
>
<li
class="slick-active"
>
<button>
1
</button>
</li>
</ul>
</div>
</div>
`;
Expand All @@ -127,6 +253,7 @@ exports[`Carousel should works for dotPosition top 1`] = `
>
<div
class="slick-slider slick-initialized"
dir="ltr"
>
<div
class="slick-list"
Expand All @@ -135,6 +262,20 @@ exports[`Carousel should works for dotPosition top 1`] = `
class="slick-track"
style="opacity: 1; transform: translate3d(0px, 0px, 0px);"
>
<div
aria-hidden="true"
class="slick-slide slick-cloned"
data-index="-1"
style="width: 0px;"
tabindex="-1"
>
<div>
<div
style="width: 100%; display: inline-block;"
tabindex="-1"
/>
</div>
</div>
<div
aria-hidden="false"
class="slick-slide slick-active slick-current"
Expand All @@ -149,8 +290,34 @@ exports[`Carousel should works for dotPosition top 1`] = `
/>
</div>
</div>
<div
aria-hidden="true"
class="slick-slide slick-cloned"
data-index="1"
style="width: 0px;"
tabindex="-1"
>
<div>
<div
style="width: 100%; display: inline-block;"
tabindex="-1"
/>
</div>
</div>
</div>
</div>
<ul
class="slick-dots slick-dots-top"
style="display: block;"
>
<li
class="slick-active"
>
<button>
1
</button>
</li>
</ul>
</div>
</div>
`;
2 changes: 1 addition & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@
"@ant-design/colors": "^7.0.2",
"@ant-design/cssinjs": "^1.18.5",
"@ant-design/icons": "^5.3.5",
"@ant-design/react-slick": "~1.0.2",
"@ant-design/react-slick": "~1.1.1",
"@babel/runtime": "^7.24.1",
"@ctrl/tinycolor": "^3.6.1",
"@rc-component/color-picker": "~1.5.3",
Expand Down

0 comments on commit 69df931

Please sign in to comment.