Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added Node 22 to prebuild list and tests #54

Merged
merged 3 commits into from
May 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
build-group: linux
- os: macos-latest
build-group: darwin
- os: windows-2019
- os: windows-latest
build-group: win32
name: Build ${{ matrix.build-group }}
runs-on: ${{ matrix.os }}
Expand Down
6 changes: 2 additions & 4 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ jobs:
strategy:
fail-fast: false
matrix:
node: [16, 18, 20]
os: [ubuntu-latest, macos-latest, windows-2019]
node: [16, 18, 20, 22]
os: [ubuntu-latest, macos-latest, windows-latest]
name: Node v${{ matrix.node }} (${{ matrix.os }})
runs-on: ${{ matrix.os }}
timeout-minutes: 10
Expand All @@ -38,8 +38,6 @@ jobs:
run: python --version
- name: Install setuptools
run: pip install setuptools
- name: Update npm
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since y'all dropped 12 and 14 upgrading npm is no longer needed as 16 ships with 8

run: npm install -g npm@8
- name: Install dependencies
run: npm ci
- name: Show node-gyp version
Expand Down
Loading
Loading