Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(install): fix go get path #422

Merged
merged 2 commits into from
Apr 19, 2024
Merged

docs(install): fix go get path #422

merged 2 commits into from
Apr 19, 2024

Conversation

tomershafir
Copy link
Contributor

Pull request type

Please check the type of change your PR introduces:

  • Documentation content changes

Checklist

  • Linter passes correctly
  • Add tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

Does this introduce a breaking change?

  • No

@vfoucault
Copy link
Contributor

Hello, I am not sure to follow that change, both URL are working fine. What is the motivation here ?

@tomershafir
Copy link
Contributor Author

sorry, wrong change, fixed in new commit

vfoucault
vfoucault approved these changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@vfoucault vfoucault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vfoucault vfoucault merged commit e34dec1 into ContentSquare:master Apr 19, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vfoucault vfoucault vfoucault approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomershafir @vfoucault