Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pool config for redis #409

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

rfyiamcool
Copy link
Contributor

@rfyiamcool rfyiamcool commented Mar 14, 2024

Description

add poolsize config for redis. the default pool size of the go-redis is small, when many concurrent request to redis, the size of the connection pool affects performance. if the redis pool is full, then all conn in pool is busy, we need to wait a while.

I think we customize the size according to the requirements.

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Further comments

@mga-chka
Copy link
Collaborator

please, check the failing tests

Signed-off-by: rfyiamcool <rfyiamcool@163.com>
@rfyiamcool rfyiamcool force-pushed the feat/add_redis_pool branch from de359ce to c809bb7 Compare March 15, 2024 13:57
@mga-chka
Copy link
Collaborator

fyi, there are still some issues with the tests

Signed-off-by: rfyiamcool <rfyiamcool@163.com>
@rfyiamcool
Copy link
Contributor Author

fyi, there are still some issues with the tests

done, have fixed wrong unit-test.

Copy link
Collaborator

@mga-chka mga-chka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. We'll release a new version of chproxy in the next 2 weeks.

@mga-chka mga-chka merged commit 7c4c82c into ContentSquare:master Mar 18, 2024
3 of 5 checks passed
@mga-chka
Copy link
Collaborator

mga-chka commented Apr 4, 2024

@rfyiamcool fyi I've released a new version of chproxy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants