Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to pass max_results_row, extremes and result_overflow_mode params #37

Merged
merged 2 commits into from
Sep 20, 2018
Merged

Allow to pass max_results_row, extremes and result_overflow_mode params #37

merged 2 commits into from
Sep 20, 2018

Conversation

hagen1778
Copy link
Contributor

#34

@hagen1778 hagen1778 requested a review from valyala September 18, 2018 19:09
valyala
valyala approved these changes Sep 20, 2018
View reviewed changes
Copy link
Contributor

@valyala valyala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you mention the added params in README.md in a separate commit?

@valyala valyala merged commit ba8e195 into master Sep 20, 2018
@valyala valyala deleted the allow-limit-params branch September 21, 2018 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valyala valyala valyala approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hagen1778 @valyala