Allow to configure server's read/write/idle timeouts #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valyala
suggested changes
Sep 20, 2018
README.md
Outdated
| @@ -430,6 +430,19 @@ server: | |||
| # By default requests are accepted from all the IPs. | |||
| allowed_networks: ["office", "reporting-apps", "1.2.3.4"] | |||
|
|
|||
| # ReadTimeout is the maximum duration for reading the entire | |||
| # request, including the body. | |||
There was a problem hiding this comment.
Could you specify on which side this timeout is applied - on the chproxy client or on the clickhouse server? Probably, it would be better adding the corresponding prefix to these timeouts? For instance, client_read_timeout
There was a problem hiding this comment.
That's the good point! I was sure being a part of server.http and/or server.https section was clear enough. But adding a prefix to the properties names could be verbose a bit. I suggest to specify details in description instead. Do you agree?
| @@ -630,49 +630,6 @@ func TestNewTLSConfig(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| func TestGetMaxResponseTime(t *testing.T) { | |||
There was a problem hiding this comment.
Could you add tests verifying config.TimeoutCfg fields are correctly set for various input configs?
There was a problem hiding this comment.
Please, see update
valyala
approved these changes
Sep 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#35