fix: executeWithRetry, save the request body and write the body to th…

[JingmaoYou]

…e request before we process it

Description

#293
The req.Body could only be read once, so when we retry the query, the body is empty, which will lead to a 400 error.

Pull request type

Please check the type of change your PR introduces:

• Bugfix
• Feature
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no api changes)
• Build related changes
• Documentation content changes
• Other (please describe):

Checklist

• Linter passes correctly
• Add tests which fail without the change (if possible)
• All tests passing
• Extended the README / documentation, if necessary

Does this introduce a breaking change?

• Yes
• No

Further comments

[mga-chka]

don't you need to close this req.Body at some point in the loop? (If not, why doing the req.Body.Close() line 208?

[JingmaoYou]

Yes, you are right, I need to close the body of the request. I change the code and use defer req.Body.Close(). The request Body needs to be closed immediately after reading it.

[gontarzpawel]

I don't think you should defer it because you're in the infinite loop that can override multiple times req.Body

[JingmaoYou]

Ok, since the defer is executed when the surrounding function returns, it will not execute when the body is updated. I will close the req.Body after reading or updating it.

[mga-chka]

it might be worth doing a simple test sending 100ks http queries in a short amount of time to chproxy to be sure there are no side effects

[JingmaoYou]

it might be worth doing a simple test sending 100ks http queries in a short amount of time to chproxy to be sure there are no side effects

I will add one test in the main_test.go file.