GOCR not working?

[mdales]

With the latest code (as of 23/6/2019) I can't get GOCR to work on either macOS or Debian Linux based maven container image.

43  [main] ERROR org.contentmine.ami.tools.AMIOCRTool  - Cannot run GOCR
java.lang.NullPointerException
	at org.contentmine.norma.image.ocr.GOCRConverter.runGOCR(GOCRConverter.java:425)
	at org.contentmine.ami.tools.AMIOCRTool.runOCR(AMIOCRTool.java:246)
	at org.contentmine.ami.tools.AMIOCRTool.processImageDir(AMIOCRTool.java:421)
	at org.contentmine.ami.tools.ImageDirProcessor.processImageDir(ImageDirProcessor.java:91)
	at org.contentmine.ami.tools.ImageDirProcessor.processImageDirs(ImageDirProcessor.java:60)
	at org.contentmine.ami.tools.AMIOCRTool.processTree(AMIOCRTool.java:218)
	at org.contentmine.ami.tools.AbstractAMITool.processTrees(AbstractAMITool.java:579)
	at org.contentmine.ami.tools.AMIOCRTool.runSpecifics(AMIOCRTool.java:210)
	at org.contentmine.ami.tools.AbstractAMITool.runCommands(AbstractAMITool.java:258)
	at org.contentmine.ami.tools.AMIOCRTool.main(AMIOCRTool.java:188)
>image.6.1.96_553/raw>
>skip gocr>raw.png

This was working earlier in the week for me, so I assume it's related to a recent change @petermr ?

[petermr]

I am committing again soon (this evening I hope).
I have not had issues with this code, but we've probably got different versions.
What is the context? -what is it being run from.

[petermr]

I have run the ami-stata testStack without NPEs:

MacBook-Pro-3:normami pm286$ source  src/test/java/org/contentmine/ami/tools/testStack.sh > src/test/java/org/contentmine/ami/tools/testStack.log
............  trying pxH-fix by Hxp -12  -7   0   3
#       fixed by Hxp to  709   5  12  15
#  trying pxH-fix by Hxp -14  -7   0   3
#       fixed by Hxp to  818   6  13  16
#............MacBook-Pro-3:normami pm286$ 

If you checkout the latest version , edit testStack.sh to point to your StataDirectory and run the above command we can compare notes.

thoughts on managing the test corpus would be useful so we always have a clean version.

[mdales]

This is the PDF that I was struggling with.
fulltext.pdf

Note tesseract worked.

[petermr]

OK - we should set up a test that runs ami on just this PDF. Where would you like to put the test? I can do it within the normami framework or you may want to have a separate area?

…

On Mon, Jun 24, 2019 at 10:08 AM Michael Dales ***@***.***> wrote: This is the PDF that I was struggling with. fulltext.pdf <https://github.com/ContentMine/normami/files/3320063/fulltext.pdf> Note tesseract worked. — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#5?email_source=notifications&email_token=AAFTCS6FWBZEF33EQADTGATP4CFJJA5CNFSM4H2ZB2RKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYMI64I#issuecomment-504926065>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAFTCS6273JUU6U2GOPZO5LP4CFJJANCNFSM4H2ZB2RA> .

-- Peter Murray-Rust Founder ContentMine.org and Reader Emeritus in Molecular Informatics Dept. Of Chemistry, University of Cambridge, CB2 1EW, UK