Implement DOI resolver recommendation #75
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petermr
reviewed
Oct 23, 2019
|
You're welcome :-) I'm not sure about these build errors, but reading the error messages, I don't think they were caused by my change. |
|
Katrin,
The active code development is now on https://github.com/petermr/ami3 (I
think your fail was a missing library). Could you please try that.
Thanks
…On Tue, Nov 19, 2019 at 12:19 PM Katrin Leinweber ***@***.***> wrote:
I'm not sure about these build errors
<https://travis-ci.org/ContentMine/norma/builds/601742819#L639-L641>, but
reading the error messages, I don't think they were caused by my change.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#75?email_source=notifications&email_token=AAFTCS6KVYTL5H57N2GVCH3QUPKWDA5CNFSM4JD7BCJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEN77MQ#issuecomment-555483058>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFTCSYEMWEJD7X6EVYFYMTQUPKWDANCNFSM4JD7BCJA>
.
--
Peter Murray-Rust
Founder ContentMine.org
and
Reader Emeritus in Molecular Informatics
Dept. Of Chemistry, University of Cambridge, CB2 1EW, UK
|
|
Not immediately, sorry. That code seems much larger and the old resolver is present in many more files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://www.doi.org/doi_handbook/3_Resolution.html#3.8
I have a script that could switch all these old DOI URLs, but I'm guessing that is only useful for some filetypes or uses.
If I'm guessing correctly and you are interested in more such PRs, please let me know where the updates are most useful.